From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash' Date: Sat, 10 Nov 2018 22:18:00 +0200 Message-ID: <83sh08adqf.fsf@gnu.org> References: <2d3e93b9-5fd4-418f-afe5-b14df2476fe6@default> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541881864 3078 195.159.176.226 (10 Nov 2018 20:31:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Nov 2018 20:31:04 +0000 (UTC) Cc: 33335-done@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 10 21:31:00 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLZuF-0000g4-JT for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 21:30:59 +0100 Original-Received: from localhost ([::1]:39860 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLZwM-0005qx-2V for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 15:33:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLZw0-0004Sk-V5 for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 15:32:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLZih-0001Mm-BA for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 15:19:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40753) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLZig-0001MO-Jk for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 15:19:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gLZig-0002St-FE for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 15:19:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Nov 2018 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33335 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 33335@debbugs.gnu.org, eliz@gnu.org, drew.adams@oracle.com Original-Received: via spool by 33335-done@debbugs.gnu.org id=D33335.15418811269442 (code D ref 33335); Sat, 10 Nov 2018 20:19:02 +0000 Original-Received: (at 33335-done) by debbugs.gnu.org; 10 Nov 2018 20:18:46 +0000 Original-Received: from localhost ([127.0.0.1]:45009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLZiQ-0002SE-GZ for submit@debbugs.gnu.org; Sat, 10 Nov 2018 15:18:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLZiO-0002Rp-D1 for 33335-done@debbugs.gnu.org; Sat, 10 Nov 2018 15:18:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLZiE-00019M-W5 for 33335-done@debbugs.gnu.org; Sat, 10 Nov 2018 15:18:39 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLZiD-00018k-Tc; Sat, 10 Nov 2018 15:18:34 -0500 Original-Received: from [176.228.60.248] (port=2698 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gLZi6-0001c9-Pu; Sat, 10 Nov 2018 15:18:33 -0500 In-reply-to: <2d3e93b9-5fd4-418f-afe5-b14df2476fe6@default> (message from Drew Adams on Sat, 10 Nov 2018 11:12:40 -0800 (PST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152270 Archived-At: > Date: Sat, 10 Nov 2018 11:12:40 -0800 (PST) > From: Drew Adams > > Both of these doc strings seem to say that if function > `system-move-file-to-trash' is defined then it is used, regardless of > the value of option `trash-directory'. > > A cursory look at the code defining `move-file-to-trash' suggests > otherwise. And that would seem to make sense, giving users a way > to customize the directory in all cases. > > Are the doc strings wrong, or am I misreading the code? It's a (subtle) bug, which I just fixed. Thanks.