From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34263: 26.1; documentation for kmacro-insert-counter C-u is wrong Date: Fri, 01 Feb 2019 12:00:09 +0200 Message-ID: <83sgx7ygk6.fsf@gnu.org> References: <83o97wzwd2.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112195"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34263@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 01 11:02:56 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpVey-000SyH-2m for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Feb 2019 11:02:56 +0100 Original-Received: from localhost ([127.0.0.1]:45024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpVew-0007F2-Ry for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Feb 2019 05:02:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpVd9-000662-Do for bug-gnu-emacs@gnu.org; Fri, 01 Feb 2019 05:01:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpVd8-0008Sz-IM for bug-gnu-emacs@gnu.org; Fri, 01 Feb 2019 05:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpVd8-0008Sv-Eb for bug-gnu-emacs@gnu.org; Fri, 01 Feb 2019 05:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gpVd8-0006nB-Cb for bug-gnu-emacs@gnu.org; Fri, 01 Feb 2019 05:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Feb 2019 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34263 X-GNU-PR-Package: emacs Original-Received: via spool by 34263-submit@debbugs.gnu.org id=B34263.154901522226054 (code B ref 34263); Fri, 01 Feb 2019 10:01:02 +0000 Original-Received: (at 34263) by debbugs.gnu.org; 1 Feb 2019 10:00:22 +0000 Original-Received: from localhost ([127.0.0.1]:53750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpVcT-0006m9-Rv for submit@debbugs.gnu.org; Fri, 01 Feb 2019 05:00:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpVcR-0006lw-RT for 34263@debbugs.gnu.org; Fri, 01 Feb 2019 05:00:20 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpVcM-0008A7-Dx; Fri, 01 Feb 2019 05:00:14 -0500 Original-Received: from [176.228.60.248] (port=4822 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gpVcM-0005aZ-0c; Fri, 01 Feb 2019 05:00:14 -0500 In-reply-to: (message from Allen Li on Thu, 31 Jan 2019 13:41:41 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154967 Archived-At: > From: Allen Li > Date: Thu, 31 Jan 2019 13:41:41 -0800 > Cc: 34263@debbugs.gnu.org > > On Thu, Jan 31, 2019 at 7:21 AM Eli Zaretskii wrote: > > > > > From: Allen Li > > > Date: Thu, 31 Jan 2019 09:54:28 +0000 > > > > > > The documentation for the behavior of C-u argument to > > > kmacro-insert-counter is wrong everywhere (both in the docstring and > > > manual, and also for kmacro-start-macro-or-insert-counter). > > > > Isn't this the same issue as the one you raised in bug#31243? Which > > is already solved in the Git repository for Emacs 26.2? > > > > > It says that supplying C-u is the same as supplying C-u 0. This is > > > completely wrong, and has caused confusion for multiple users (I can > > > dig up some links if desired). C-u 0 inserts the current value of the > > > kmacro counter without incrementing it. C-u inserts the *previous* > > > value of the kmacro counter, which is usually one less than the > > > current value. > > > > Please look at the documentation on the emacs-26 branch and tell what > > exactly is wrong/unclear/confusing there. > > On both the master branch and emacs-26: > > (defun kmacro-insert-counter (arg) > "Insert current value of `kmacro-counter', then increment it by ARG. > Interactively, ARG defaults to 1. With \\[universal-argument], insert > current value of `kmacro-counter', but do not increment it." > > This is still wrong, C-u inserts the *previous* value of kmacro-counter. How do you suggest to define "previous" to avoid the confusion? That was the reason for bug#31243. We must add to the documentation the definition of "previous" that would be clear and unequivocal. Thanks.