From: Eli Zaretskii <eliz@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: [RFC]: replace-region-contents
Date: Tue, 05 Feb 2019 18:11:40 +0200 [thread overview]
Message-ID: <83sgx2tdtv.fsf@gnu.org> (raw)
In-Reply-To: <878syubwv3.fsf@gnu.org> (message from Tassilo Horn on Tue, 05 Feb 2019 06:57:52 +0100)
> From: Tassilo Horn <tsdh@gnu.org>
> Date: Tue, 05 Feb 2019 06:57:52 +0100
> Cc: emacs-devel@gnu.org
>
> I don't have a preference. I guess Eli might argue that this version
> encourages passing strings around instead of using buffers.
Not just strings, _large_ strings. Small strings are okay, we even
have a special optimization for them. Large strings are much less
efficient, in both memory management and access, than buffers. And in
the context of the function we are talking about, the probability of a
string to be large is IMO very high.
I'm not against a string as an option, though.
> I'd explain in the doc string that in the case of a string return
> value, we're going thru a temporary buffer anyway, so if your
> REPLACE-FN ends in (buffer-substring ...), you're clearly doing
> something wrong...
Right, thanks.
next prev parent reply other threads:[~2019-02-05 16:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 21:20 [RFC]: replace-region-contents Tassilo Horn
2019-02-02 9:33 ` Marcin Borkowski
2019-02-02 13:57 ` Tassilo Horn
2019-02-02 15:42 ` Stefan Monnier
2019-02-04 5:23 ` Tassilo Horn
2019-02-05 2:56 ` Stefan Monnier
2019-02-05 5:57 ` Tassilo Horn
2019-02-05 13:21 ` Tassilo Horn
2019-02-05 16:36 ` Eli Zaretskii
2019-02-05 17:19 ` Tassilo Horn
2019-02-06 16:00 ` Eli Zaretskii
2019-02-06 17:02 ` Tassilo Horn
2019-02-06 17:33 ` Eli Zaretskii
2019-02-06 18:07 ` Tassilo Horn
2019-02-08 16:23 ` Tassilo Horn
2019-02-08 16:28 ` Stefan Monnier
2019-02-08 17:17 ` Tassilo Horn
2019-02-08 21:37 ` Eli Zaretskii
2019-02-08 21:53 ` Stefan Monnier
2019-02-08 21:27 ` Eli Zaretskii
2019-02-08 22:03 ` Tassilo Horn
2019-02-08 22:19 ` Eli Zaretskii
2019-02-09 0:00 ` Tassilo Horn
2019-02-09 8:26 ` Eli Zaretskii
2019-02-09 8:52 ` Tassilo Horn
2019-02-05 13:43 ` Stefan Monnier
2019-02-06 8:07 ` Tassilo Horn
2019-02-06 9:55 ` Marcin Borkowski
2019-02-06 11:10 ` Tassilo Horn
2019-02-06 14:09 ` Stefan Monnier
2019-02-05 16:11 ` Eli Zaretskii [this message]
2019-02-02 16:17 ` Stefan Monnier
2019-02-03 15:59 ` Eli Zaretskii
2019-02-03 17:05 ` Stefan Monnier
2019-02-03 17:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sgx2tdtv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.