all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex Branham <alex.branham@gmail.com>
Cc: 34419@debbugs.gnu.org
Subject: bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el
Date: Mon, 11 Feb 2019 17:51:31 +0200	[thread overview]
Message-ID: <83sgwul3wc.fsf@gnu.org> (raw)
In-Reply-To: <87o97jnzw9.fsf@gmail.com> (message from Alex Branham on Sun, 10 Feb 2019 14:37:26 -0600)

> From: Alex Branham <alex.branham@gmail.com>
> Date: Sun, 10 Feb 2019 14:37:26 -0600
> 
> I'd like to apply the following patch to enable lexical binding in
> conf-mode.el.

Can you tell how did you test the result to make sure no bugs will be
introduced by lexical-binding in this package?  I see no test suite
for it.

> OK to apply to master, or should I split the documentation
> changes into a separate commit and apply it to emacs-26?

The changes to the documentation are too minor to bother splitting
them, IMO.

> (conf-align-assignments):
> (conf-quote-normal):
> (conf-mode-initialize): Fix documentation

There's no file name in this log message, and it is under-filled (did
you use change-log-mode?).  Also, our style is to say "Doc fix" or
"Docstring fix" in these cases.  Finally, please mention the bug
number in the log message.

Thanks.





  reply	other threads:[~2019-02-11 15:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-10 20:37 bug#34419: 27.0.50; [PATCH] Use lexical-binding in conf-mode.el Alex Branham
2019-02-11 15:51 ` Eli Zaretskii [this message]
2019-02-11 22:26   ` Alex Branham
2019-02-15  8:46     ` Eli Zaretskii
2019-02-15 13:26       ` Alex Branham
2019-02-15 14:10         ` Eli Zaretskii
2019-02-18 17:17           ` Alex Branham
2019-02-18 17:44             ` Eli Zaretskii
2019-02-19 15:52               ` Alex Branham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sgwul3wc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=34419@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.