From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36609: 27.0.50; Possible race-condition in threading implementation Date: Sat, 13 Jul 2019 18:54:40 +0300 Message-ID: <83sgraylof.fsf@gnu.org> References: <87muhks3b5.fsf@hochschule-trier.de> <83muhj2zmb.fsf@gnu.org> <83ims72xcj.fsf@gnu.org> <83a7dj2sz9.fsf@gnu.org> <835zo72jmr.fsf@gnu.org> <834l3r2jbe.fsf@gnu.org> <8336jb2fhq.fsf@gnu.org> <83wogmyo1k.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135341"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36609@debbugs.gnu.org, politza@hochschule-trier.de To: pipcet@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 13 17:55:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmKMd-000Z36-Ds for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 17:55:07 +0200 Original-Received: from localhost ([::1]:56954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmKMb-0005In-Qc for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 11:55:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40724) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmKMZ-0005I0-Av for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 11:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmKMY-0005mP-CI for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 11:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmKMY-0005mD-8j for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 11:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmKMY-00059k-6C for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 11:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36609 X-GNU-PR-Package: emacs Original-Received: via spool by 36609-submit@debbugs.gnu.org id=B36609.156303330119811 (code B ref 36609); Sat, 13 Jul 2019 15:55:02 +0000 Original-Received: (at 36609) by debbugs.gnu.org; 13 Jul 2019 15:55:01 +0000 Original-Received: from localhost ([127.0.0.1]:43220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmKMX-00059T-7M for submit@debbugs.gnu.org; Sat, 13 Jul 2019 11:55:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmKMU-00059D-QT for 36609@debbugs.gnu.org; Sat, 13 Jul 2019 11:54:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmKMP-0005Uz-2x; Sat, 13 Jul 2019 11:54:53 -0400 Original-Received: from [176.228.60.248] (port=2649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmKMO-0004bG-Fn; Sat, 13 Jul 2019 11:54:52 -0400 In-reply-to: <83wogmyo1k.fsf@gnu.org> (message from Eli Zaretskii on Sat, 13 Jul 2019 18:03:35 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162915 Archived-At: > Date: Sat, 13 Jul 2019 18:03:35 +0300 > From: Eli Zaretskii > Cc: 36609@debbugs.gnu.org, politza@hochschule-trier.de > > But I still would like to understand why we need to maintain a flag > per thread. Specifically, why not make this flag thread-independent, and have any thread release the context lock if that variable is non-zero? I don't think it matters which thread locked the Glib context, we just need to release it once we emerge from thread_select, and do it before we might call Fsignal. That the lock might be released by a thread other than the one which locked it shouldn't matter, I think, as long as we consider all the Lisp threads acting together on behalf of Emacs.