From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Date: Wed, 07 Aug 2019 17:42:14 +0300 Message-ID: <83sgqdavg9.fsf@gnu.org> References: <875znjntfe.fsf@mail.linkov.net> <83mugvhr66.fsf@gnu.org> <871ry6rksu.fsf@mail.linkov.net> <83zhksexvx.fsf@gnu.org> <87sgqhricg.fsf@mail.linkov.net> <87o914u65x.fsf@mail.linkov.net> <04C790C7-2667-4480-BDC9-BE838D307A74@aol.com> <837e7qcpbj.fsf@gnu.org> <20190806175146.fpgzslvlaydpih7k@Ergus> <831rxycfqp.fsf@gnu.org> <2F586079-3687-4DF0-984D-467F442E68D1@aol.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="244899"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36861@debbugs.gnu.org, juri@linkov.net To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 07 16:43:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvN9h-0011Zd-Ef for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 16:43:09 +0200 Original-Received: from localhost ([::1]:41974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvN9g-0001JV-Bj for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 10:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43117) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvN9b-0001JO-L6 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:43:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvN9a-0002I9-Mb for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvN9a-0002Hv-Ig for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvN9a-0003n7-E4 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 10:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2019 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36861-submit@debbugs.gnu.org id=B36861.156518895214536 (code B ref 36861); Wed, 07 Aug 2019 14:43:02 +0000 Original-Received: (at 36861) by debbugs.gnu.org; 7 Aug 2019 14:42:32 +0000 Original-Received: from localhost ([127.0.0.1]:39199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvN95-0003mO-TI for submit@debbugs.gnu.org; Wed, 07 Aug 2019 10:42:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvN94-0003mB-7A for 36861@debbugs.gnu.org; Wed, 07 Aug 2019 10:42:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hvN8y-0001yr-Jk; Wed, 07 Aug 2019 10:42:24 -0400 Original-Received: from [176.228.60.248] (port=2375 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hvN8x-0003fa-Mo; Wed, 07 Aug 2019 10:42:24 -0400 In-reply-to: <2F586079-3687-4DF0-984D-467F442E68D1@aol.com> (message from Ergus on Tue, 06 Aug 2019 21:25:00 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164715 Archived-At: > Date: Tue, 06 Aug 2019 21:25:00 +0200 > CC: juri@linkov.net,36861@debbugs.gnu.org > From: Ergus > > We can do that... I was just trying to avoid using ?| by default in any case. Why should we avoid that? It might be not the best alternative, but at least it lets users who just set the mode variable have an indicator. If they want a prettier display, they will have to call the mode function instead, as they do now. So I think this is a net win. Or am I missing something? > There is also the case when a user sets ?| by default and then call the function. If the check we add is just > comparing to the default value then ?| will be always overwritten so an extra internal variable will be needed to > cache where the ?| comes from. Not sure we need another variable. After all, if the conditions stayed the same, the result will be the same as well, and you will overwrite the value with an identical one. Right?