From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13824: 24.3.50; :package-version not taking priority over :version Date: Sat, 10 Aug 2019 12:22:02 +0300 Message-ID: <83sgq98jet.fsf@gnu.org> References: <87txozc7c4.fsf@bzg.ath.cx> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157938"; mail-complaints-to="usenet@blaine.gmane.org" Cc: bzg@altern.org, 13824@debbugs.gnu.org To: Stefan Kangas , Bill Wohler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 10 11:23:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hwNaf-000exs-1h for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Aug 2019 11:23:09 +0200 Original-Received: from localhost ([::1]:35534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwNad-0007fx-Ss for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Aug 2019 05:23:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35091) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwNaZ-0007fc-5z for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwNaY-0002bj-4n for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwNaY-0002bf-1x for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hwNaX-0006cc-OF for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 05:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Aug 2019 09:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 13824-submit@debbugs.gnu.org id=B13824.156542893825386 (code B ref 13824); Sat, 10 Aug 2019 09:23:01 +0000 Original-Received: (at 13824) by debbugs.gnu.org; 10 Aug 2019 09:22:18 +0000 Original-Received: from localhost ([127.0.0.1]:43463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwNZp-0006bO-Pa for submit@debbugs.gnu.org; Sat, 10 Aug 2019 05:22:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwNZo-0006bB-GW for 13824@debbugs.gnu.org; Sat, 10 Aug 2019 05:22:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hwNZi-0002A9-Pn; Sat, 10 Aug 2019 05:22:10 -0400 Original-Received: from [176.228.60.248] (port=3716 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hwNZg-0006rd-OP; Sat, 10 Aug 2019 05:22:10 -0400 In-reply-to: (message from Stefan Kangas on Thu, 8 Aug 2019 05:59:21 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164832 Archived-At: > From: Stefan Kangas > Date: Thu, 8 Aug 2019 05:59:21 +0200 > Cc: 13824@debbugs.gnu.org > > Bastien Guerry writes: > > > The docstring of `defcustom' says: > > > > :package-version > > VALUE should be a list with the form (PACKAGE . VERSION) > > specifying that the variable was first introduced, or its > > default value was changed, in PACKAGE version VERSION. This > > keyword takes priority over :version. > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > but `describe-variable-custom-version-info' gives priority to :version > > over :package-version. Which one is correct here? > > This is still an issue on current master (and 26.2). > > I reproduced this using: > > (progn > (defcustom foobar nil > "foo" > :version "27.1" > :package-version '(foo . "1")) > (describe-variable-custom-version-info 'foobar)) > > Which results in: > > "This variable was introduced, or its default value was changed, in > version 27.1 of Emacs. > " > > But C-h f defcustom says: > > :package-version > VALUE should be a list with the form (PACKAGE . VERSION) > specifying that the variable was first introduced, or its > default value was changed, in PACKAGE version VERSION. This > keyword takes priority over :version. The implementation only prefers :package-version for the purposes of customize-changed-options, i.e. the Options->Customize Emacs->New Options menu item. By contrast, describe-variable-custom-version-info is used for displaying the doc strings of options. For a package that is bundled with Emacs, I think displaying :version in "C-h v" makes sense. If people agree, then this is a minor documentation bug (also to be fixed in the ELisp manual), not a code bug. Bill, what is your take on this? Your change, which introduced this attribute, only modified customize-changed-options. Was that on purpose?