From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: PATCH: isearch-yank-until-char Date: Wed, 14 Aug 2019 20:51:38 +0300 Message-ID: <83sgq3r5xx.fsf@gnu.org> References: <87tvakfnv4.fsf@red-bean.com> <835zmzsuau.fsf@gnu.org> <87d0h77l8d.fsf@red-bean.com> <87woff64ri.fsf@red-bean.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="168314"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 14 19:52:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hxxS4-000heM-P8 for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2019 19:52:48 +0200 Original-Received: from localhost ([::1]:34686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxxS3-0006Oz-KZ for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2019 13:52:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37999) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxxR7-0006F7-QQ for emacs-devel@gnu.org; Wed, 14 Aug 2019 13:51:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hxxR7-0003iM-Fn; Wed, 14 Aug 2019 13:51:49 -0400 Original-Received: from [176.228.60.248] (port=2167 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hxxR6-0004Nm-Er; Wed, 14 Aug 2019 13:51:49 -0400 In-reply-to: <87woff64ri.fsf@red-bean.com> (message from Karl Fogel on Wed, 14 Aug 2019 12:22:41 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239365 Archived-At: > From: Karl Fogel > Date: Wed, 14 Aug 2019 12:22:41 -0500 > > There's another similar situation going on with the entries in `isearch-menu-bar-yank-map'. Many of them say "on search string" when they should say "to search string". It's clearly a copy-and-paste error from the first entry, `isearch-yank-pop' (where the "on" is correct for reasons special to that function). I noticed the problem when I was making my patch, but my patch was not the place to fix it, since it's unrelated. I was just going to do a separate typo-fix commit later for this. Here's that code, so you don't have to dig it up: Yes, noted. As a matter of fact, that code is sitting on my desk, waiting to be fixed soon. There are also doc strings that need fixing, etc. Let's concentrate on the new command for now, okay?