all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Karl Fogel <kfogel@red-bean.com>
Cc: emacs-devel@gnu.org
Subject: Re: PATCH: isearch-yank-until-char
Date: Wed, 14 Aug 2019 20:51:38 +0300	[thread overview]
Message-ID: <83sgq3r5xx.fsf@gnu.org> (raw)
In-Reply-To: <87woff64ri.fsf@red-bean.com> (message from Karl Fogel on Wed, 14 Aug 2019 12:22:41 -0500)

> From: Karl Fogel <kfogel@red-bean.com>
> Date: Wed, 14 Aug 2019 12:22:41 -0500
> 
> There's another similar situation going on with the entries in `isearch-menu-bar-yank-map'.  Many of them say "on search string" when they should say "to search string".  It's clearly a copy-and-paste error from the first entry, `isearch-yank-pop' (where the "on" is correct for reasons special to that function).  I noticed the problem when I was making my patch, but my patch was not the place to fix it, since it's unrelated.  I was just going to do a separate typo-fix commit later for this.  Here's that code, so you don't have to dig it up:

Yes, noted.  As a matter of fact, that code is sitting on my desk,
waiting to be fixed soon.  There are also doc strings that need
fixing, etc.

Let's concentrate on the new command for now, okay?



  reply	other threads:[~2019-08-14 17:51 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14  3:05 PATCH: isearch-yank-until-char Karl Fogel
2019-08-14 14:20 ` Eli Zaretskii
2019-08-14 16:41   ` Karl Fogel
2019-08-14 16:48     ` Drew Adams
2019-08-14 17:20       ` Eli Zaretskii
2019-08-14 17:22       ` Karl Fogel
2019-08-14 17:51         ` Eli Zaretskii [this message]
2019-08-14 17:59 ` Noam Postavsky
2019-08-14 20:39   ` Juri Linkov
2019-08-14 20:34 ` Juri Linkov
2019-08-16  4:53   ` Karl Fogel
2019-08-16 17:52     ` Juri Linkov
2019-08-25  2:14       ` Karl Fogel
2019-08-25  3:22         ` Drew Adams
2019-08-25 20:03           ` Juri Linkov
2019-08-26  1:14             ` Drew Adams
2019-08-26  5:20           ` Karl Fogel
2019-08-26 14:50             ` Drew Adams
2019-08-26 17:51               ` Karl Fogel
2019-08-26 19:36                 ` Drew Adams
2019-08-26 21:29                   ` Karl Fogel
2019-08-26 21:57                     ` Drew Adams
2019-08-26 22:21                       ` Karl Fogel
2019-08-26 22:43                         ` Drew Adams
2019-09-04 16:47                           ` Karl Fogel
2019-09-04 17:00                             ` Eli Zaretskii
2019-09-12 17:44                               ` Karl Fogel
2019-09-16 21:24                   ` Drew Adams
2019-09-17 16:02                     ` Karl Fogel
2019-08-26 21:46                 ` Juri Linkov
2019-08-26 21:52                   ` Karl Fogel
2019-08-26 22:03                   ` Drew Adams
2019-08-26 22:19                     ` Juri Linkov
2019-08-26 22:33                       ` Karl Fogel
2019-08-26 22:40                       ` Drew Adams
2019-08-27 21:31                         ` Juri Linkov
2019-08-27 22:52                           ` Drew Adams
2019-08-27 23:15                             ` Drew Adams
2019-08-25 19:58         ` Juri Linkov
2019-08-14 22:26 ` Stefan Monnier
2019-08-15 18:24   ` Juri Linkov
2019-08-17 12:31     ` Stefan Monnier
2019-08-17 22:51       ` Juri Linkov
2019-08-16  5:11   ` Karl Fogel
     [not found] <<87tvakfnv4.fsf@red-bean.com>
     [not found] ` <<835zmzsuau.fsf@gnu.org>
2019-08-14 15:24   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sgq3r5xx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.