From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Date: Wed, 02 Oct 2019 05:28:15 +0300 Message-ID: <83sgob98zk.fsf@gnu.org> References: <87y2y5lfnb.fsf@1e0.co.uk> <83eezxatsv.fsf@gnu.org> <87tv8slb6w.fsf@mattleach.net> <83a7aka1q5.fsf@gnu.org> <87sgocfh8c.fsf@mattleach.net> <83y2y48f8u.fsf@gnu.org> <87o8z0few1.fsf@mattleach.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110368"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37564@debbugs.gnu.org To: Matthew Leach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 02 04:29:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFUOB-000ScB-27 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Oct 2019 04:29:15 +0200 Original-Received: from localhost ([::1]:50768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFUO9-0004Dp-R1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 22:29:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42295) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFUO1-0004Dd-7F for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 22:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFUNz-0002Q3-AR for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 22:29:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFUNy-0002Pd-NH for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 22:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFUNy-0006Mk-H7 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 22:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Oct 2019 02:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37564-submit@debbugs.gnu.org id=B37564.156998331824440 (code B ref 37564); Wed, 02 Oct 2019 02:29:01 +0000 Original-Received: (at 37564) by debbugs.gnu.org; 2 Oct 2019 02:28:38 +0000 Original-Received: from localhost ([127.0.0.1]:35266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFUNa-0006M8-BQ for submit@debbugs.gnu.org; Tue, 01 Oct 2019 22:28:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:32851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFUNX-0006Lu-Jq for 37564@debbugs.gnu.org; Tue, 01 Oct 2019 22:28:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFUNQ-0001qi-U4; Tue, 01 Oct 2019 22:28:30 -0400 Original-Received: from [176.228.60.248] (port=3350 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFUNO-0000i0-HI; Tue, 01 Oct 2019 22:28:28 -0400 In-reply-to: <87o8z0few1.fsf@mattleach.net> (message from Matthew Leach on Tue, 01 Oct 2019 20:24:14 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168114 Archived-At: > From: Matthew Leach > Cc: 37564@debbugs.gnu.org > Date: Tue, 01 Oct 2019 20:24:14 +0100 > > > I simply tried "env | fgrep LINES" and I do see the variable, although > > it wasn't there before I launched Emacs. > > I would expect the variable to be there when inside Emacs as it has > exported it. You should find that it won't exist if ran outside Emacs, > for example in xterm. Sorry, I'm confused. Are we talking about running "M-x term" inside Emacs, or are we talking about something else? The subject of the bug report says "term", so I assumed you mean term-mode. > Ah, indeed if I try and resize and print the variable it has updated: > > matthew@hopton ~ $ env | grep -i lines > LINES=30 > matthew@hopton ~ $ env | grep -i lines > LINES=12 > > I think the issue is that the environment can't be while a process is > running; the environment variables are fixed when the program has > started. For a ncurses application this presents a problem as LINES and > COLUMNS can't be updated when the window size is changed and the program > handles a SIGWINCH. You can see that on the output above. While the process is running, Emacs sends ioctl commands to communicate the window size changes.