From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37667: 27.0.50; Tab Bar display problems with more than 5 tabs Date: Tue, 29 Oct 2019 14:01:05 +0200 Message-ID: <83sgnbpxq6.fsf@gnu.org> References: <83o8yrvzgh.fsf@gnu.org> <83eezjrbuj.fsf@gnu.org> <87sgnw2pz3.fsf@mail.linkov.net> <83o8yjke0u.fsf@gnu.org> <87lftnqbmg.fsf@mail.linkov.net> <83h84agytj.fsf@gnu.org> <87tv89opbh.fsf@mail.linkov.net> <83mue1g845.fsf@gnu.org> <83lftlg6zc.fsf@gnu.org> <87lftlk504.fsf@mail.linkov.net> <83eezceir2.fsf@gnu.org> <87pniwuwj5.fsf@mail.linkov.net> <83blufdehy.fsf@gnu.org> <878spj57dk.fsf@mail.linkov.net> <83v9sm8rs3.fsf@gnu.org> <87blubaw63.fsf@mail.linkov.net> <83zhhu34xz.fsf@gnu.org> <8736fl91vp.fsf@mail.linkov.net> <834l0024lr.fsf@gnu.org> <87eez4pjfk.fsf@mail.linkov.net> <83ftjjzbln.fsf@gnu.org> <87d0egpjec.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="198141"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37667@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 29 13:02:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPQCW-000pKe-7v for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2019 13:02:16 +0100 Original-Received: from localhost ([::1]:55648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPQCU-0002Er-Hx for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Oct 2019 08:02:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42895) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPQCJ-0002At-52 for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2019 08:02:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPQCH-0000gF-VR for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2019 08:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38159) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPQCH-0000g8-Rg for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2019 08:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPQCH-0006yo-Mv for bug-gnu-emacs@gnu.org; Tue, 29 Oct 2019 08:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Oct 2019 12:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37667 X-GNU-PR-Package: emacs Original-Received: via spool by 37667-submit@debbugs.gnu.org id=B37667.157235047626773 (code B ref 37667); Tue, 29 Oct 2019 12:02:01 +0000 Original-Received: (at 37667) by debbugs.gnu.org; 29 Oct 2019 12:01:16 +0000 Original-Received: from localhost ([127.0.0.1]:46980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPQBX-0006xl-V8 for submit@debbugs.gnu.org; Tue, 29 Oct 2019 08:01:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iPQBW-0006xY-RW for 37667@debbugs.gnu.org; Tue, 29 Oct 2019 08:01:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iPQBR-0008VO-Gb; Tue, 29 Oct 2019 08:01:09 -0400 Original-Received: from [176.228.60.248] (port=3827 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iPQBQ-0000V2-Fs; Tue, 29 Oct 2019 08:01:09 -0400 In-reply-to: <87d0egpjec.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 29 Oct 2019 00:38:19 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170362 Archived-At: > From: Juri Linkov > Cc: 37667@debbugs.gnu.org > Date: Tue, 29 Oct 2019 00:38:19 +0200 > > I'm still trying to understand why truncation flags are not set in the tab-line. > Test case: > > 0. emacs -Q > 1. M-x global-tab-line-mode RET > 2. C-x b 01234567890123456789012345678901234567890123456789 RET > more buffers with long names might be needed > to cause the tab-line truncation > > 3. M-x dump-glyph-row RET > > shows no truncation: > > Row Start End Used oE><\CTZFesm X Y W H V A P > ============================================================================== > 0 0 0 111 110000000000 0 0 677 16 0 12 9 > > i.e. the columns '>' ('row->truncated_on_right_p') > and '<' ('row->truncated_on_right_p') both have values '0'. > > Is this a bug? Or maybe there is another way to detect tab-line truncation > in the glyph matrix? These flags are reset because display_mode_line forcibly resets them: it.glyph_row->full_width_p = true; it.glyph_row->continued_p = false; it.glyph_row->truncated_on_left_p = false; it.glyph_row->truncated_on_right_p = false; I think you will find that before the last two lines are executed, the truncated_on_right_p flag is set for the tab-line in your example. I think we need to make a change there to not reset the last 2 flags when we are displaying the tab-line. (The full_width_p flag should still be set, because we don't want margin areas on the tab-line.)