From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38457: 27.0.50; dabbrev-expand regression due to message change Date: Mon, 02 Dec 2019 18:02:16 +0200 Message-ID: <83sgm2lnqv.fsf@gnu.org> References: <8736e3vve8.fsf@gmx.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="195550"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38457@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 02 17:04:32 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iboBc-000oeu-6w for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 17:04:32 +0100 Original-Received: from localhost ([::1]:37908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iboBa-0007am-Aa for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Dec 2019 11:04:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52451) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iboAD-000694-Dt for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 11:03:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iboAC-0001Qm-70 for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 11:03:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iboAA-0001Q1-IQ for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 11:03:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iboAA-0000B5-Ep for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2019 11:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2019 16:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38457 X-GNU-PR-Package: emacs Original-Received: via spool by 38457-submit@debbugs.gnu.org id=B38457.1575302554645 (code B ref 38457); Mon, 02 Dec 2019 16:03:02 +0000 Original-Received: (at 38457) by debbugs.gnu.org; 2 Dec 2019 16:02:34 +0000 Original-Received: from localhost ([127.0.0.1]:38809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibo9i-0000AL-7f for submit@debbugs.gnu.org; Mon, 02 Dec 2019 11:02:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibo9g-0000A4-E3 for 38457@debbugs.gnu.org; Mon, 02 Dec 2019 11:02:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ibo9b-0001BK-8m; Mon, 02 Dec 2019 11:02:27 -0500 Original-Received: from [176.228.60.248] (port=3197 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ibo9a-0005sL-HA; Mon, 02 Dec 2019 11:02:27 -0500 In-reply-to: <8736e3vve8.fsf@gmx.net> (message from Stephen Berman on Mon, 02 Dec 2019 12:06:55 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172771 Archived-At: > From: Stephen Berman > Date: Mon, 02 Dec 2019 12:06:55 +0100 > > 0. emacs -Q > 1. M-! te M-/ > > => It takes about 4 seconds on my machine for the expansion "text" to > appear, during which the minibuffer displays "[Scanning for > dabbrevs...100%]" and then "[Scanning for dabbrevs...done]". On builds > without this regression, the expansion is virtually instantaneous and no > message is seen in the minibuffer. > > Git bisect pinpoints the following change: > > aa89c84e00d8dc85100e6fedab7631c415e6364d is the first bad commit > commit aa89c84e00d8dc85100e6fedab7631c415e6364d > Author: Juri Linkov > Date: Wed Nov 27 01:43:49 2019 +0200 > > message uses minibuffer-message in the active minibuffer (bug#17272 bug#19064) > > * doc/lispref/display.texi (Displaying Messages): Explain the > behavior of using minibuffer-message if the minibuffer is active. > > * src/editfns.c (Fmessage_in_echo_area): New function with body > copied from Fmessage. > (Fmessage): Call minibuffer-message in the active minibuffer, > otherwise call Fmessage_in_echo_area. > (message-in-echo-area): New variable. > > * lisp/isearch.el (isearch--momentary-message, isearch-message): > * lisp/minibuffer.el (minibuffer-message, minibuffer-completion-help): > Use 'message-in-echo-area' instead of 'message' where necessary. > > * lisp/autorevert.el (auto-revert-handler): > * lisp/man.el (Man-bgproc-sentinel): > * lisp/subr.el (do-after-load-evaluation): > Revert recent changes that replaced 'message' with 'minibuffer-message'. > This is not needed anymore since 'message' uses 'minibuffer-message' > in the active minibuffer. I guess the new message-in-echo-area confuses dabbrev.el because it switches buffers, and dabbrev.el has special logic for that, which triggers the message, and the subsequent wait.