all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: James Felix Black <jfb@homonculus.net>
Cc: 38675@debbugs.gnu.org
Subject: bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation
Date: Sat, 21 Dec 2019 11:38:36 +0200	[thread overview]
Message-ID: <83sgleyq5f.fsf@gnu.org> (raw)
In-Reply-To: <728CF61C-FC25-4B59-BFC0-C6CBC5A626F8@homonculus.net> (message from James Felix Black on Thu, 19 Dec 2019 12:49:01 -0500)

> From: James Felix Black <jfb@homonculus.net>
> Date: Thu, 19 Dec 2019 12:49:01 -0500
> 
> This was discovered in `haskell-mode` [1]. The documentation of  define-obsolete-face-alias claims that `when` is optional, but the macro definition does not follow the docs. This patch fixes the problem.

I'm not sure this isn't a confusion caused by ambiguous wording of the
doc string.  I think by "if provided" it means that WHEN can be nil.
The ELisp manual, btw, doesn't have this problem.

Would it be okay to modify the doc string instead to say WHEN is
required, but can be nil?

Thanks.





  reply	other threads:[~2019-12-21  9:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 17:49 bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation James Felix Black
2019-12-21  9:38 ` Eli Zaretskii [this message]
2019-12-21 17:54   ` Glenn Morris
2019-12-21 22:47   ` James Felix Black
2019-12-28  9:15     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sgleyq5f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38675@debbugs.gnu.org \
    --cc=jfb@homonculus.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.