From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373) Date: Fri, 03 Jan 2020 22:13:25 +0200 Message-ID: <83sgkwguxm.fsf@gnu.org> References: <20191226000417.69183-1-phst@google.com> <83v9psgz1x.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="94896"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30373@debbugs.gnu.org, p.stephani2@gmail.com, sjindel@google.com To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 03 21:14:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inTKp-000OW4-EZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 21:14:15 +0100 Original-Received: from localhost ([::1]:56512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inTKi-00052S-FV for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 15:14:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46052) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inTKd-00052L-2u for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:14:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inTKc-0007mi-5A for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inTKc-0007mC-18 for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inTKb-0005TW-S5 for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2020 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30373 X-GNU-PR-Package: emacs Original-Received: via spool by 30373-submit@debbugs.gnu.org id=B30373.157808241421001 (code B ref 30373); Fri, 03 Jan 2020 20:14:01 +0000 Original-Received: (at 30373) by debbugs.gnu.org; 3 Jan 2020 20:13:34 +0000 Original-Received: from localhost ([127.0.0.1]:41490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inTKA-0005Sf-Ge for submit@debbugs.gnu.org; Fri, 03 Jan 2020 15:13:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inTK8-0005SR-Rn for 30373@debbugs.gnu.org; Fri, 03 Jan 2020 15:13:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inTK3-0006U9-BV; Fri, 03 Jan 2020 15:13:27 -0500 Original-Received: from [176.228.60.248] (port=3810 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inTK2-0001wj-F5; Fri, 03 Jan 2020 15:13:27 -0500 In-reply-to: (message from Pip Cet on Fri, 3 Jan 2020 18:53:46 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174132 Archived-At: > From: Pip Cet > Date: Fri, 3 Jan 2020 18:53:46 +0000 > Cc: Philipp Stephani , 30373@debbugs.gnu.org, sjindel@google.com > > If I'm reading the test correctly, it depends on garbage-collect > actually collecting an unreferenced vector; since our GC's > conservative, that might not be working for you, if a word that > happens to look like a reference to the vector is still on the stack. > (Or it might be something else entirely, but I don't think the test as > it stands is correct). You are probably right, because I see the same failure on GNU/Linux, in an x86_64 unoptimized build: Test module/function-finalizer condition: (ert-test-failed ((should (equal (mod-test-function-finalizer-calls) expected-calls)) :form (equal (0 0) (1 0)) :value nil :explanation (list-elt 0 (different-atoms (0 "#x0" "?") (1 "#x1" "?"))))) FAILED 26/27 module/function-finalizer (0.247565 sec)