From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: 30373@debbugs.gnu.org, p.stephani2@gmail.com, sjindel@google.com
Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373)
Date: Fri, 03 Jan 2020 22:13:25 +0200 [thread overview]
Message-ID: <83sgkwguxm.fsf@gnu.org> (raw)
In-Reply-To: <CAOqdjBcgnDZXqayB7rCa5zVu+Wmygbf0mXGQ3J8n3xBnc1xewQ@mail.gmail.com> (message from Pip Cet on Fri, 3 Jan 2020 18:53:46 +0000)
> From: Pip Cet <pipcet@gmail.com>
> Date: Fri, 3 Jan 2020 18:53:46 +0000
> Cc: Philipp Stephani <p.stephani2@gmail.com>, 30373@debbugs.gnu.org, sjindel@google.com
>
> If I'm reading the test correctly, it depends on garbage-collect
> actually collecting an unreferenced vector; since our GC's
> conservative, that might not be working for you, if a word that
> happens to look like a reference to the vector is still on the stack.
> (Or it might be something else entirely, but I don't think the test as
> it stands is correct).
You are probably right, because I see the same failure on GNU/Linux,
in an x86_64 unoptimized build:
Test module/function-finalizer condition:
(ert-test-failed
((should
(equal
(mod-test-function-finalizer-calls)
expected-calls))
:form
(equal
(0 0)
(1 0))
:value nil :explanation
(list-elt 0
(different-atoms
(0 "#x0" "?")
(1 "#x1" "?")))))
FAILED 26/27 module/function-finalizer (0.247565 sec)
next prev parent reply other threads:[~2020-01-03 20:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 21:17 bug#30373: Support finalizers for functions created in dynamic modules Samir Jindel
2019-12-23 20:41 ` Philipp Stephani
2019-12-26 0:04 ` bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373) Philipp Stephani
2020-01-03 18:34 ` Philipp Stephani
2020-01-03 18:44 ` Eli Zaretskii
2020-01-03 18:53 ` Pip Cet
2020-01-03 20:13 ` Eli Zaretskii [this message]
2020-01-03 20:49 ` Pip Cet
2020-01-04 19:56 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sgkwguxm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30373@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
--cc=pipcet@gmail.com \
--cc=sjindel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.