From: Eli Zaretskii <eliz@gnu.org>
To: JD Smith <jdtsmith@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Popup-menu signals quit when Aborted
Date: Sat, 01 Feb 2020 17:14:54 +0200 [thread overview]
Message-ID: <83sgjuibkh.fsf@gnu.org> (raw)
In-Reply-To: <97CB42CE-5971-4EA5-B96C-6FA7620DDB74@gmail.com> (message from JD Smith on Sat, 1 Feb 2020 09:51:22 -0500)
> From: JD Smith <jdtsmith@gmail.com>
> Date: Sat, 1 Feb 2020 09:51:22 -0500
>
> `x-popup-menu` is setup to handle mouse events specially when “aborting” the menu by clicking off of it:
>
> > If the user gets rid of the menu without making a valid choice, for
> > instance by clicking the mouse away from a valid choice or by typing
> > keyboard input, then this normally results in a quit and
> > ‘x-popup-menu’ does not return. But if POSITION is a mouse button
> > event (indicating that the user invoked the menu with the mouse) then
> > no quit occurs and ‘x-popup-menu’ returns nil.
>
> This seems sensible. But `popup-menu` "normalizes" all incoming positions using `popup-menu-normalize-position`, which strips any mouse event designation in the position before passing it on. So there is no way via `popup-menu` to "indicat[e] that the user invoked the menu with the mouse”. Hence it always quits and ring the bell when the user “gets rid of the menu".
>
> Normalizing away mouse events in this manner seems like a bug in `popup-menu` to me, since `x-popup-menu` explicitly takes mouse events and behaves differently with them.
>
> See https://github.com/tarsius/minions/issues/25 for original discussion.
Sorry, I don't understand the goal of the report. You seem to be
talking about internal workings of popup-menu (which has to handle
both GUI and text-mode menus, btw), and I don't think I understand why
these internal workings are of any interest to applications that use
popup-menu. Can you explain this point?
IOW, what would you like to see, in terms of behavior _external_ to
popup-menu?
And a short recipe, starting from "emacs -Q" and showing the problem,
would be most appreciated.
Thanks.
next prev parent reply other threads:[~2020-02-01 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 14:51 Popup-menu signals quit when Aborted JD Smith
2020-02-01 15:14 ` Eli Zaretskii [this message]
2020-02-01 15:55 ` Stefan Monnier
2020-02-01 16:41 ` JD Smith
2020-02-01 16:47 ` Stefan Monnier
2020-02-01 21:58 ` JD Smith
2020-02-01 16:48 ` Eli Zaretskii
2020-02-01 21:58 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sgjuibkh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jdtsmith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.