From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#1474: 23.0.60; desktop.el don't check if pid in his lock file is always in use Date: Mon, 27 Apr 2020 17:50:09 +0300 Message-ID: <83sggp3rvi.fsf@gnu.org> References: <87bpvufe28.fsf@tux.homenetwork> <87v9p094ym.fsf@marxist.se> <87eev56tuu.fsf@marxist.se> <83v9ohcdi7.fsf@gnu.org> <87r1w98bfj.fsf@stefankangas.se> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="109349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs@gentoo.org, 1474@debbugs.gnu.org, thierry.volpiatto@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 27 16:54:00 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jT58y-000SME-46 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Apr 2020 16:54:00 +0200 Original-Received: from localhost ([::1]:49566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT58x-0006kH-4I for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Apr 2020 10:53:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59092) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT566-0002US-UJ for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 10:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jT566-0000IV-Fn for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 10:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jT565-0000Hp-Ro for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 10:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jT565-0002K8-QV for bug-gnu-emacs@gnu.org; Mon, 27 Apr 2020 10:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Apr 2020 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1474 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 1474-submit@debbugs.gnu.org id=B1474.15879990238864 (code B ref 1474); Mon, 27 Apr 2020 14:51:01 +0000 Original-Received: (at 1474) by debbugs.gnu.org; 27 Apr 2020 14:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:37806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT55T-0002Is-AK for submit@debbugs.gnu.org; Mon, 27 Apr 2020 10:50:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jT55S-0002Ie-2S for 1474@debbugs.gnu.org; Mon, 27 Apr 2020 10:50:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36966) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jT55L-0007E8-9t; Mon, 27 Apr 2020 10:50:15 -0400 Original-Received: from [176.228.60.248] (port=2771 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jT55K-00009Z-Bb; Mon, 27 Apr 2020 10:50:14 -0400 In-Reply-To: <87r1w98bfj.fsf@stefankangas.se> (message from Stefan Kangas on Mon, 27 Apr 2020 12:34:08 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179149 Archived-At: > From: Stefan Kangas > Cc: emacs@gentoo.org, 1474@debbugs.gnu.org, thierry.volpiatto@gmail.com > Date: Mon, 27 Apr 2020 12:34:08 +0200 > > >> +(defun desktop--emacs-pid-running-p (pid) > >> + "Return t if an Emacs process with PID exists." > >> + (when-let ((attr (process-attributes pid))) > >> + (string-match "^emacs$" (alist-get 'comm attr)))) > > > > I understand the rationale for the string-match test, but what if the > > executable file name of Emacs was "transformed", per the > > '--program-transform-name' option of the configure script? And even > > if it wasn't transformed, this will not match emacs-XX.YY and > > emacs.exe. > > Good point. But would you suggest to use no check at all, or is there > some other check we could reasonably use? I assume it is impossible > to use the process name due to '--program-transform-name'. Perhaps you could use the name you find in command-line-args? Note that it might include leading directories, and at least on Windows the directory separator might either be a slash or a backslash, so use of file-name-nondirectory is advised.