From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40940: 27.0.91; project-query-replace-regexp stops too early Date: Fri, 01 May 2020 18:45:55 +0300 Message-ID: <83sggjveto.fsf@gnu.org> References: <871ro7ptk0.fsf@runbox.com> <9ba1394f-5a29-8e8d-93cf-9b794b8ebb98@yandex.ru> <83d07q217v.fsf@gnu.org> <87ftcmhezl.fsf@runbox.com> <831ro61yce.fsf@gnu.org> <83zhauzlt7.fsf@gnu.org> <83mu6uzi8h.fsf@gnu.org> <32c0b31e-9165-faff-c9a0-9103d937898b@yandex.ru> <835zdgw3aj.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="19453"; mail-complaints-to="usenet@ciao.gmane.io" Cc: simenheg@runbox.com, monnier@IRO.UMontreal.CA, 40940@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 01 17:47:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUXt8-0004y6-UJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 May 2020 17:47:42 +0200 Original-Received: from localhost ([::1]:39204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUXt7-00047s-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 May 2020 11:47:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUXsV-0003L2-Tf for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 11:47:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUXsV-0007sO-9j for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 11:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38927) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUXsU-0007rR-T3 for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 11:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUXsU-00036z-RM for bug-gnu-emacs@gnu.org; Fri, 01 May 2020 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 May 2020 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40940 X-GNU-PR-Package: emacs Original-Received: via spool by 40940-submit@debbugs.gnu.org id=B40940.158834798811893 (code B ref 40940); Fri, 01 May 2020 15:47:02 +0000 Original-Received: (at 40940) by debbugs.gnu.org; 1 May 2020 15:46:28 +0000 Original-Received: from localhost ([127.0.0.1]:50466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUXrh-00035O-U9 for submit@debbugs.gnu.org; Fri, 01 May 2020 11:46:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUXrg-00035C-T1 for 40940@debbugs.gnu.org; Fri, 01 May 2020 11:46:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57443) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUXra-0006kz-Tq; Fri, 01 May 2020 11:46:06 -0400 Original-Received: from [176.228.60.248] (port=1679 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUXra-0008TW-16; Fri, 01 May 2020 11:46:06 -0400 In-Reply-To: (message from Dmitry Gutov on Fri, 1 May 2020 18:27:45 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179440 Archived-At: > Cc: simenheg@runbox.com, monnier@IRO.UMontreal.CA, 40940@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 1 May 2020 18:27:45 +0300 > > On 01.05.2020 09:57, Eli Zaretskii wrote: > > I see no reference to either case-fold-search or > > case-fold in isearch-no-upper-case-p. So why would we need to update > > its doc string? > > Sorry if that was unclear: I think we'd need to update the docstring of > fileloop-initialize-replace. Which doesn't offer any hints that the > logic of isearch-no-upper-case-p will be employed. Ah, okay. Agreed. > > Does that really work in the case in point? Unless I'm missing > > something, if case-fold-search is t by default, this patch would cause > > the search to be case-insensitive even if the FROM regexp includes > > upper-case characters. But in that case, perform-replace will > > internally decide to be case-sensitive, and we have the same failure > > on our hands. This is why the patch I proposed explicitly examined > > the FROM regexp for upper-case characters. Whereas yours doesn't. > > Since we bind search-upper-case to nil in this patch, perform-replace > won't try to alter the value of case-fold-search internally. But that's contrary to how query-replace works, isn't it?