From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 41125-done@debbugs.gnu.org, pipcet@gmail.com
Subject: bug#41125: 28.0.50; Fwindow_text_pixel_size uses FETCH_CHAR (charpos)
Date: Fri, 08 May 2020 13:37:42 +0300 [thread overview]
Message-ID: <83sggaiufd.fsf@gnu.org> (raw)
In-Reply-To: <a938f63d-d1e5-693e-b4a9-7a4840f25ee7@gmx.at> (message from martin rudalics on Fri, 8 May 2020 09:18:27 +0200)
> Cc: 41125@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
> Date: Fri, 8 May 2020 09:18:27 +0200
>
> >> which cannot possibly be correct: FETCH_CHAR takes a byte position,
> >> not a character position, but BEGV and ZV are measured in characters.
> >
> > Ouch! Thanks. Does the patch below look good?
>
> It does. Thanks for fixing yet another of my blunders in this function.
> And thanks to Pip for catching it.
Thanks, I pushed the fix to the emacs-27 branch.
prev parent reply other threads:[~2020-05-08 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 11:55 bug#41125: 28.0.50; Fwindow_text_pixel_size uses FETCH_CHAR (charpos) Pip Cet
2020-05-07 13:36 ` Eli Zaretskii
2020-05-08 7:18 ` martin rudalics
2020-05-08 10:37 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sggaiufd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41125-done@debbugs.gnu.org \
--cc=pipcet@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.