From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26911: 25.2; eshell "cd .." doesn't work correctly with TRAMP Date: Sat, 29 Aug 2020 21:26:51 +0300 Message-ID: <83sgc5xq8k.fsf@gnu.org> References: <693aa189-03fa-b963-89eb-ce19c51ba325@cs.ucla.edu> <83wo1jz32t.fsf@gnu.org> <83sgc7z220.fsf@gnu.org> <83r1rryrk0.fsf@gnu.org> <47047d69-91aa-fd0d-1510-64ba7c246970@cs.ucla.edu> <83a6yeynd1.fsf@gnu.org> <03a31052-795a-c169-c199-2b0f3ba88ec2@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33578"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de, yegortimoshenko@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 29 20:28:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kC5aH-0008d7-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 20:28:13 +0200 Original-Received: from localhost ([::1]:59574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC5aG-0003hE-Hn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Aug 2020 14:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kC5a6-0003gj-U1 for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 14:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kC5a6-0003xB-JW for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 14:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kC5a6-0002qY-Gw for bug-gnu-emacs@gnu.org; Sat, 29 Aug 2020 14:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Aug 2020 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26911 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 26911-submit@debbugs.gnu.org id=B26911.159872563110870 (code B ref 26911); Sat, 29 Aug 2020 18:28:02 +0000 Original-Received: (at 26911) by debbugs.gnu.org; 29 Aug 2020 18:27:11 +0000 Original-Received: from localhost ([127.0.0.1]:49116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC5ZH-0002pG-11 for submit@debbugs.gnu.org; Sat, 29 Aug 2020 14:27:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kC5ZE-0002p2-LE for 26911@debbugs.gnu.org; Sat, 29 Aug 2020 14:27:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56829) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC5Z9-0003q2-8i; Sat, 29 Aug 2020 14:27:03 -0400 Original-Received: from [176.228.60.248] (port=1217 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kC5Z4-0004nz-OW; Sat, 29 Aug 2020 14:27:02 -0400 In-Reply-To: <03a31052-795a-c169-c199-2b0f3ba88ec2@cs.ucla.edu> (message from Paul Eggert on Sat, 29 Aug 2020 09:46:29 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186671 Archived-At: > Cc: 26911@debbugs.gnu.org, mattiase@acm.org, michael.albinus@gmx.de, > yegortimoshenko@gmail.com > From: Paul Eggert > Date: Sat, 29 Aug 2020 09:46:29 -0700 > > >> I installed the attached patch to revert the recent expand-file-changes in the > >> DOS_NT case, which should fix the problem you mentioned. > > > > Thanks, it does. But it produces a different problem: > > > > (expand-file-name "." "c:/foo/bar/") => "c:/foo/bar > > > > (note the absence of the trailing slash). > > That's what Emacs 27 does on MS-Windows, no? So it's not a regression, and the > problem can be fixed at the convenience of whoever's interested in hacking on > the MS-Windows side of the code. It's a regression wrt behavior on Posix platforms: it fails one of the tests in fileio-tests.el: Test fileio-tests--HOME-trailing-slash condition: (ert-test-failed ((should (equal (expand-file-name "~") (expand-file-name home))) :form (equal "c:/a/b/c" "c:/a/b/c/") :value nil :explanation (arrays-of-different-length 8 9 "c:/a/b/c" "c:/a/b/c/" first-mismatch-at 8))) FAILED 1/12 fileio-tests--HOME-trailing-slash (0.000000 sec) > Another way to put it is that Bug#26911 is now fixed for GNU and POSIX, but not > for MS-Windows. My earlier changes attempted to fix it for all platforms, but > this had undesirable side-effects in MS-Windows so I withdrew the MS-Windows > part of the changes. I have therefore reopened Bug#26911 since I assume it's > still present on MS-Windows. If that is the case, I prefer that we revert all the changes made recently to fix bug#26911, and leave that bug open, until a fix is available that works on all platforms. > > I'm not interested in messing with expand-file-name > > That's understandable as expand-file-name is quite a mess internally. But if > you're not interested in any attempt to clean up the mess, I guess I should > refrain from giving it a shot. Fine with me, then let's revert the recent changes and go back to what we had before. Thanks for trying to fix that.