all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: master ac6b62b: * lisp/time.el (world-clock-mode): Make non-interactive.
Date: Fri, 23 Apr 2021 09:09:37 +0300	[thread overview]
Message-ID: <83sg3ho7ku.fsf@gnu.org> (raw)

>     * lisp/time.el (world-clock-mode): Make non-interactive.
> ---
>  lisp/time.el | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lisp/time.el b/lisp/time.el
> index 5abc6e9..fd53f63 100644
> --- a/lisp/time.el
> +++ b/lisp/time.el
> @@ -534,6 +534,7 @@ If the value is t instead of an alist, use the value of
>  (define-derived-mode world-clock-mode special-mode "World clock"
>    "Major mode for buffer that displays times in various time zones.
>  See `world-clock'."
> +  :interactive nil
>    (setq-local revert-buffer-function #'world-clock-update)
>    (setq show-trailing-whitespace nil))

Stefan, can you give your rationale for the change?  Why should user
be unable to invoke this mode interactively, when they could do so for
a long time?  And in any case, why isn't that change in NEWS?

Thanks.



             reply	other threads:[~2021-04-23  6:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  6:09 Eli Zaretskii [this message]
2021-04-23  9:22 ` master ac6b62b: * lisp/time.el (world-clock-mode): Make non-interactive Stefan Kangas
2021-04-23 10:34   ` Eli Zaretskii
2021-04-23 10:58     ` Stefan Kangas
2021-04-23 11:25       ` Eli Zaretskii
2021-04-23 12:34         ` Stefan Kangas
2021-04-23 13:03           ` Eli Zaretskii
2021-04-23 13:01         ` Stefan Kangas
2021-04-23 13:17           ` Eli Zaretskii
2021-04-23 13:36             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sg3ho7ku.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.