From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Reworking loaddefs.el generation Date: Wed, 01 Jun 2022 22:02:35 +0300 Message-ID: <83sfoofbqs.fsf@gnu.org> References: <87ee0f8cvx.fsf@gnus.org> <87o7zd7ked.fsf@gnus.org> <87fskp7jbd.fsf@gnus.org> <874k157ie6.fsf@gnus.org> <87r14960bp.fsf@gnus.org> <83pmjth5du.fsf@gnu.org> <87czft4hvh.fsf@gnus.org> <83o7zdglva.fsf@gnu.org> <87zgix2k29.fsf@gnus.org> <83fskoharn.fsf@gnu.org> <87bkvc1t0e.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15722"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 01 21:03:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwTd1-0003qw-Ox for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 21:03:35 +0200 Original-Received: from localhost ([::1]:45276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwTd0-0004yi-Ae for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Jun 2022 15:03:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwTbx-0004Gl-II for emacs-devel@gnu.org; Wed, 01 Jun 2022 15:02:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41902) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwTbx-0006Nw-7L; Wed, 01 Jun 2022 15:02:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KMm5eOGAUVKEIJ6RzP0sHKHEjXogbLpNZgrTpki7SUQ=; b=Nbsu9tO2rnOw 4OpRzEJoP4j3wGKKaK3RF3n6D5kH//3eBh2tuqJMoCu07heXu5wP9GYyKM/oXODS94QsHb7KmJWW0 JR79iaZ6+i+EIdKN8AisNdQOj68OWCTRyQ8pAXMsi7beeCSY+bw1aQZGMXK0XG2zUI1tdXfK3BNij BN5nz0B4sa1D9gAxlH5dM8RQEohJY+u/lS6G5vw0wX+mlsqyxAX7/8wrc8l2wlmtA44ROQUdt6wJM 5mzrQJHFnEk2sGEFYHynytSxPfQz23jVnsyVIx71G1nwj6RDHg5tgWMsaytZbFwL2HXN4MrWrIXLL GggbWT+RwouTpJKnUHk4Fw==; Original-Received: from [87.69.77.57] (port=4071 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwTbw-0003vp-NI; Wed, 01 Jun 2022 15:02:29 -0400 In-Reply-To: <87bkvc1t0e.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 01 Jun 2022 14:13:21 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290529 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Wed, 01 Jun 2022 14:13:21 +0200 > > Eli Zaretskii writes: > > > I see this with the current master: > > > > $ touch lisp/array.el .git/logs/HEAD > > $ make -j4 > > [...] > > GEN loaddefs.el > > INFO Scraping files for loaddefs... > > INFO Scraping files for loaddefs...26% > > INFO Scraping files for loaddefs...53% > > INFO Scraping files for loaddefs...81% > > INFO Scraping files for loaddefs...done > > GEN loaddefs.el > > > > Why so much "scraping" lines for just one file modified? > > I get > > GEN loaddefs.el > INFO Scraping files for loaddefs... > INFO Scraping files for loaddefs...done > GEN loaddefs.el > > in that test case. > > The loop is: > > (dolist (file files) > (progress-reporter-update progress (setq file-count (1+ file-count))) > (when (or (not updating) > (file-newer-than-file-p file output-file)) > > > So it seems like file-newer-than-file-p is very slow on your machine > since progress-reporter manages to output several percentages? However slow file-newer-than-file-p is here, it didn't become slower since these changes were done. Before those changes, I was used to see the same as you see now: just two lines with no percents. So something did change that made the process slower, at least on this machine.