all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
Cc: 55970@debbugs.gnu.org
Subject: bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags
Date: Tue, 14 Jun 2022 21:30:19 +0300	[thread overview]
Message-ID: <83sfo7rtc4.fsf@gnu.org> (raw)
In-Reply-To: <CAOR1sLzwXLZoq=F8WvHQ9Csrc3uwR1FSEWziHE_nkWbTPw3=7Q@mail.gmail.com> (message from समीर सिंह Sameer Singh on Tue, 14 Jun 2022 23:18:42 +0530)

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Tue, 14 Jun 2022 23:18:42 +0530
> Cc: 55970@debbugs.gnu.org
> 
> Thread 1 "emacs" hit Breakpoint 1, terminate_due_to_signal (sig=6, backtrace_limit=40) at emacs.c:420
> 420     {
> (gdb) frame 2
> #2  0x000055555571ba26 in make_lispy_event (event=0x555555e25300 <kbd_buffer+256>) at
> keyboard.c:6140
> 6140              emacs_abort ();
> (gdb) p *event
> $1 = {
>  kind = SCROLL_BAR_CLICK_EVENT,
>  part = scroll_bar_handle,
>  code = 0,
>  modifiers = 0,
>  x = make_fixnum(17531),
>  y = make_fixnum(1244637),
>  timestamp = 0,
>  frame_or_window = XIL(0x5555560794a5),
>  arg = XIL(0),
>  device = XIL(0x30)
> }

Thanks.  I think the problem is here:

  static void
  pgtk_send_scroll_bar_event (Lisp_Object window, enum scroll_bar_part part,
			      int portion, int whole, bool horizontal)
  {
    union buffered_input_event inev;

    EVENT_INIT (inev.ie);

    inev.ie.kind = (horizontal
		    ? HORIZONTAL_SCROLL_BAR_CLICK_EVENT
		    : SCROLL_BAR_CLICK_EVENT);
    inev.ie.frame_or_window = window;
    inev.ie.arg = Qnil;
    inev.ie.timestamp = 0;
    inev.ie.code = 0;
    inev.ie.part = part;
    inev.ie.x = make_fixnum (portion);
    inev.ie.y = make_fixnum (whole);
    inev.ie.modifiers = 0;

    evq_enqueue (&inev);
  }

This sets the modifiers to zero, which causes the abort.  Instead, I
suggest to do this:

    inev.ie.modifiers =
      part == scroll_bar_end_scroll ? up_modifier : down_modifier;

Can you try this?





  reply	other threads:[~2022-06-14 18:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 14:08 bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags समीर सिंह Sameer Singh
2022-06-14 17:44 ` Eli Zaretskii
2022-06-14 17:48   ` समीर सिंह Sameer Singh
2022-06-14 18:30     ` Eli Zaretskii [this message]
2022-06-14 18:44       ` समीर सिंह Sameer Singh
2022-06-14 18:48         ` Eli Zaretskii
2022-06-15  0:59           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15  2:28             ` Eli Zaretskii
2022-06-15  3:29               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15  8:23                 ` समीर सिंह Sameer Singh
2022-06-15 12:25                 ` Eli Zaretskii
2022-06-15 13:14                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 13:50             ` Robert Pluim
2022-06-15 14:01               ` समीर सिंह Sameer Singh
2022-06-16  0:53               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-16  7:39                 ` Robert Pluim
2022-06-15  0:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfo7rtc4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55970@debbugs.gnu.org \
    --cc=lumarzeli30@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.