From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Fri, 26 Aug 2022 13:58:19 +0300 Message-ID: <83sflj1dbo.fsf@gnu.org> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 57400@debbugs.gnu.org To: Antoine Kalmbach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 13:10:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRXEm-0000yK-Lv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 13:10:56 +0200 Original-Received: from localhost ([::1]:47582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRXEl-0006yO-EQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 07:10:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRX3G-0006Iw-6T for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 06:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRX3F-0001Zv-Sm for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 06:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRX3F-0004nx-Oj for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 06:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2022 10:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166151149418396 (code B ref 57400); Fri, 26 Aug 2022 10:59:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 10:58:14 +0000 Original-Received: from localhost ([127.0.0.1]:52281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRX2T-0004mb-V3 for submit@debbugs.gnu.org; Fri, 26 Aug 2022 06:58:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRX2S-0004mP-QA for 57400@debbugs.gnu.org; Fri, 26 Aug 2022 06:58:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRX2N-0001TH-Io; Fri, 26 Aug 2022 06:58:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KBdki2H9GBUyw9oen195ROfzG/LXzLS9l3mFIColy5c=; b=IRjY5RwRU36j s/9mz8Azpfmcm0xdOQR5sgD90GhleW7pRJninuuj/yg4SzzaordOuQ5i3rkUG4A/0ThrPmIiEcx7R Wha0zKQvqlNTR1FeZQkAndnGn1SZc6cb6Ht/l88Ln0ibRtKk70s6g2ract0i2QhJ0kS24LiWBe/j6 1nmPzZHtKbHkVRqlva8rIfGK3hpw+LiPVuc21qTQzcraQ1aAoiG9+O+q5Sf26hTOfelWrlhtLT8u2 RVWaKUHEvWGJJoImapcLCm0BPFJON0QmTBT86opn8gzURP6oCRfnczAtHoWX0TJssrXoyR/VmOif2 YckpUMBpSzkF1MJqKlfdzQ==; Original-Received: from [87.69.77.57] (port=2689 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRX2M-0002bo-R7; Fri, 26 Aug 2022 06:58:07 -0400 In-Reply-To: (message from Antoine Kalmbach on Fri, 26 Aug 2022 13:45:51 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240804 Archived-At: > Cc: 57400@debbugs.gnu.org > From: Antoine Kalmbach > Date: Fri, 26 Aug 2022 13:45:51 +0300 > > 1. `M-x vc-prepare-patch` > 2. Dispatch to `vc-git-prepare-patch` > 3. Git wants a revision range, so interactively prompt for that > (e.g. `HEAD^`, `abcd1234..ghjk5678`, or `-1`) Please allow the user to specify the range of commits in a log-like display, e.g. by having mark and point around them. It makes no sense to force users to type revisions in the Git syntax, and come up with the SHA1 codes on top of that. VC is supposed to be a convenient UI, not just a dumb front-end to the VCS. > 4. `call-process` to `git format-patch $REV`, and so forth, get the > list of files. By "list of files" do you mean the list of patch files? > 5. Loop each file in `message-mode`. `C-c C-c` sends and goes to the > next patch, `C-c C-k` cancels the whole thing. Please don't hard-code message-mode. Please honor the user setting of mail-user-agent instead. Also, I'm not sure why we'd need to send each patch file separately. Why not add them one by one as attachments to the same email message? > Most likely, depending on the backend, we should not require any > parameters besides the "set of changes". If you allow to specify that via the region, all your problems are solved, and the only one that remains is how to express that in the backend-specific syntax.