From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 19:50:32 +0300 Message-ID: <83sfldu147.fsf@gnu.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25811"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, ams@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 18:52:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4Tr-0006W0-SC for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 18:52:51 +0200 Original-Received: from localhost ([::1]:38826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT4Tq-000525-GS for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 12:52:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4Rl-0002OH-KZ for emacs-devel@gnu.org; Tue, 30 Aug 2022 12:50:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4Rk-00085l-1U; Tue, 30 Aug 2022 12:50:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OI1crY6AMFmiq4qCzFG8yxCXnVPUEH7gnrpt1v+TmU4=; b=UnToDhqHLzpx MgA7c/+9jQX+PZApW1J5IO8uE4s0rkf7BuJAAzJIsG4m7a4b9KpMBvNGwpJsR7NV2U5Mj+3aXVIi7 Gdfnrsl7+AAeayK2DRMeSzO7p/gcSWmD/jfg0k1r2uyiHMqySfTrMotHJz/oO0gckeE9miOyek71b fnDfC3v1bjUfD2YHtpFQtGX6XQLk5BaaWuPFtRw243c64gYyq2DeOgOJuF9jA0kPBI2zFWFO9u9rS rKae+Ig8NtYWfZpF+POpGu/ZG6ftBgdbLZmQG2WQiZAXOv/mq7OhhEWAGqGAKndFERhQax1JSIDmo 1FZkWniWcs3gne4j0cmiwQ==; Original-Received: from [87.69.77.57] (port=2128 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4RE-00071K-Jr; Tue, 30 Aug 2022 12:50:23 -0400 In-Reply-To: (message from Stefan Monnier on Tue, 30 Aug 2022 11:16:17 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294357 Archived-At: > From: Stefan Monnier > Cc: "Alfred M. Szmidt" , eliz@gnu.org, larsi@gnus.org, > juri@jurta.org, emacs-devel@gnu.org > Date: Tue, 30 Aug 2022 11:16:17 -0400 > > > I can look into adapting this approach for other VCS if nobody beats me to > > it. As long as we fundamentally agree on the behavior. > > Fine by me. I'll just mention that I think we should be careful to make > sure no info is lost if Emacs crashes in the middle of the operation. Emacs never crashes.