From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Tue, 11 Oct 2022 15:55:51 +0300 Message-ID: <83sfjuecyw.fsf@gnu.org> References: <83h70qhez0.fsf@gnu.org> <83edvuhaby.fsf@gnu.org> <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> <83zgehe6iq.fsf@gnu.org> <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru> <834jwfmn5a.fsf@gnu.org> <838rlohzeo.fsf@gnu.org> <83mta2g91p.fsf@gnu.org> <237a3e26-03b8-a2a9-90bd-d50c3670a131@yandex.ru> <83wn96efyn.fsf@gnu.org> <5bb803bf-f51b-c175-f908-c60066d6967d@yandex.ru> <83v8oqeeqf.fsf@gnu.org> <7c0849be-145e-e073-49b5-63749e8d8282@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16138"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 15:37:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiFSD-000419-Q7 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 15:37:53 +0200 Original-Received: from localhost ([::1]:38452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiFSC-0005ix-CA for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 09:37:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiEnU-0006aT-KB for emacs-devel@gnu.org; Tue, 11 Oct 2022 08:55:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiEnQ-0007KI-7g; Tue, 11 Oct 2022 08:55:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BAwyF78Fy6W6zUMBati0OyQknA6FXWvTlDIlDLqQx10=; b=JOIUjBG/9tmV Ujfr/ZvbfAqhnBF4w/n36ksRh6WJnNIZGzWrOrGvkaQE/8/FvQHjPY7jc8hBVEtGGERM++d9ue8mz vah2DSJDaIWyrDwzJFO6sS2kGiJf6ipvUD/3iKIvAh0DHsO5MxTN1FWyCvqmmPCpC/JsoZb3cEXaa nVlGNhVCn8tB55wMTwRpm1MHRbLUhTAcQoUkZEE65cjRX32HuDu6pAhkc0AufTUTmuTsviss7iqUE WFWrvErQPEjEndDNeN8yJYT5/tSOOuIxwaoJOz4a4edipauyF8eiXwGPsrTOu+aLNqygR7sH89Zyq A/Hxu+SJ3uUyL/+FoKwVtA==; Original-Received: from [87.69.77.57] (port=4732 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiEnO-0008HP-Fa; Tue, 11 Oct 2022 08:55:43 -0400 In-Reply-To: <7c0849be-145e-e073-49b5-63749e8d8282@yandex.ru> (message from Dmitry Gutov on Tue, 11 Oct 2022 15:44:18 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297480 Archived-At: > Date: Tue, 11 Oct 2022 15:44:18 +0300 > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > > On 11.10.2022 15:17, Eli Zaretskii wrote: > > >>> Its problem is that it > >>> states the fact, but doesn't attempt to explain it, and thus doesn't > >>> give a clue what the user did wrong and how to fix that. > >> > >> How does one explain that we cannot replace in xref-find-definitions > >> results? > > > > That's what the "subset of matches of identifier" part attempts to do. > > A high-level and not very accurate description, because it's only > relevant for the difference between xref-find-definitions vs > xref-find-references, but not when the *-find-regexp commands come into > play. I know. As I said, suggestions for better wording will be moist welcome. > But we can try to be helpful by offering an alternative: > > Cannot replace in this search; to rename a symbol, invoke > \\[xref-find-references] first But then we'd need to name the other 2 commands as well, to be accurate, yes? > >> Perhaps I should remind that xref-find-definitions is still the main > >> exception -- where this command doesn't work. > > > > But not the only one? > > The only known one, so far. So maybe just saying Cannot do global replacement using results of \\[xref-find-definitions] should be okay? > That would mean that one 'r' can work in lsp-mode's > xref-find-definitions results (they define a bunch of custom commands > like lsp-find-definition and lsp-find-declaration, but that probably > doesn't matter). Not sure if we should do something about that. If 'r' happens to work in that case, we don't have to worry about the error message, right?