From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Date: Thu, 03 Nov 2022 08:25:32 +0200 Message-ID: <83sfj08sgz.fsf@gnu.org> References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7431"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58909@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 03 07:26:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqTgJ-0001g5-2d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Nov 2022 07:26:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqTg2-00059p-9d; Thu, 03 Nov 2022 02:26:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqTfu-000583-PV for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 02:26:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqTfu-0000WD-H4 for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 02:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqTfu-0003kx-C7 for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2022 02:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2022 06:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166745674814420 (code B ref 58909); Thu, 03 Nov 2022 06:26:02 +0000 Original-Received: (at 58909) by debbugs.gnu.org; 3 Nov 2022 06:25:48 +0000 Original-Received: from localhost ([127.0.0.1]:47620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqTfg-0003kV-0i for submit@debbugs.gnu.org; Thu, 03 Nov 2022 02:25:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqTfe-0003kJ-DV for 58909@debbugs.gnu.org; Thu, 03 Nov 2022 02:25:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqTfZ-0000Td-6m; Thu, 03 Nov 2022 02:25:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n+mFryrloSe2zbRgSw57A+U7jfabiQU7V+ZT0hmbXbA=; b=gmEaoEJcm4sM svT6PQohCPF3skS6Zv3oqDWj6RTz9HfBoAtyZKvZbHtnA5JX+TIkjU+KpgOiHZuk88uyBPvC2DEVD CqHelajRgYuiH/1GNwP5RNWzVD6/+YTnTh+JwMC4zfeol7C1PhwHVEW+5P/2nWatZx1u/7+2ooaha nkS4WC2zuy4XOMXQC6oe4Ww1rVyHD9+sCR32j8QiTYqc0m2unMG4V92SCieffpw/e69dQGvFokUwO HHDef7jC4D0EElHx9Ed5++kVwU9/O80JlddP1fiMy4qbp/d83fFTneDXZfqRj2NQjXhQ+xs8et7FC Sj3ItbxIXutUssYenjAtDA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqTfX-0007Uo-KB; Thu, 03 Nov 2022 02:25:40 -0400 In-Reply-To: <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> (message from Jim Porter on Wed, 2 Nov 2022 15:09:21 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246915 Archived-At: > Date: Wed, 2 Nov 2022 15:09:21 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > >>> I'm fine with doing that, but we must also make sure this mode is > >>> turned on when users invoke server-start interactively. > >> > >> I think that makes sense, and it should be fairly straightforward. I'll > >> work on a patch for this. > > > > Thanks. > > Ok, here's a patch for that. It just sets the 'server-mode' variable > (and 'global-minor-modes' to be polite) inside 'server-start'. It would > probably be more elegant if we could make 'server-start' just call > '(server-mode)' (instead of the other way around like it is now), but I > think it would be hard to do that while staying 100% compatible. Does > this seem ok? Yes, but let's wait for a few days before installing to give people chance to chime in. Thanks.