From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Eglot, project.el, and python virtual environments Date: Fri, 18 Nov 2022 17:22:12 +0200 Message-ID: <83sfig9tjv.fsf@gnu.org> References: <87zgcq68zp.fsf@ericabrahamsen.net> <878rkale3l.fsf@dfreeman.email> <87v8nezf2k.fsf@ericabrahamsen.net> <87o7t5k7sv.fsf@dfreeman.email> <86mt8p4221.fsf@gmail.com> <4cc918a053771a5e1c440cb4b458f3ed@webmail.orcon.net.nz> <838rk8d7xb.fsf@gnu.org> <87k03swcye.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9441"; mail-complaints-to="usenet@ciao.gmane.io" Cc: psainty@orcon.net.nz, dgutov@yandex.ru, theophilusx@gmail.com, emacs-devel@gnu.org, joaotavora@gmail.com To: Danny Freeman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 18 16:22:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow3Ci-0002Fx-Ik for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Nov 2022 16:22:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow3CP-0005Ne-P7; Fri, 18 Nov 2022 10:22:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow3CA-00055M-Jm for emacs-devel@gnu.org; Fri, 18 Nov 2022 10:22:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow3Bw-0004UC-Oz; Fri, 18 Nov 2022 10:22:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IMEkXNoOPFUoHUV+iFR3ssau+fXKwPODcdfgkBhRuic=; b=nxC3btPC7t3oVsZCSU8L rcb9qB4yqSHMTAgS/8mIjZ5R9GIN2Oma+bxVBySQ/29gjFDz9ucy9jjo5CnyDdtWS5gFFhMIxQRGK 0KSqFvbShdj6WtHWDoLp+A2ZoME1b1y7yfqretsb/iUjWdKQIpo4JaRjcqw/7PUbiqLfH7EeiTSBn WcdQ9PEqancRCqdF/v/fi16Og6loFLdwfsgpeismDwA93ERU9Omd+PFT/TZLqDtsCpAUiAIUyICd8 4kDEj1d1GH5ic5up+2VfSQMl4pw7Ve0W4ShwKi9iGW4zOGO38H99wgkvwLgipy5gl3A9tuAvPcdCI 71ViBtbx2AMrOQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow3Bw-0006sb-90; Fri, 18 Nov 2022 10:22:08 -0500 In-Reply-To: <87k03swcye.fsf@dfreeman.email> (message from Danny Freeman on Fri, 18 Nov 2022 08:55:35 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300110 Archived-At: > From: Danny Freeman > Cc: Phil Sainty , Dmitry Gutov , > theophilusx@gmail.com, emacs-devel@gnu.org, João Távora > Date: Fri, 18 Nov 2022 08:55:35 -0500 > > > Eli Zaretskii writes: > > > I think this turns the table for no good reason. I see no reason to > > add complex new abstractions to project.el just because we have an > > issue with configuring Eglot in the use case presented in this thread. > > > > Let me remind you that Eglot already supports a kind of "sub-project": > > it uses the same LSP server only for those source files in a project > > that share the same major mode. So parts of a project that use a > > different PL are already considered to be a "sub-project", and Eglot > > does that without any help from project.el. > > > > Given that this feature already exists, a proposal to add a > > "sub-project" notion to project.el should describe at least several > > use cases of such "sub-projects" where the separate "sub-projects" > > share the same programming language. If the situation with python-env > > is the only one we find reasonable, IMO adding "sub-projects" to > > project.el is an unjustified complication. > > I think that most monorepo projects fall into this category. That is a > large version controlled repository with multiple sub projects in it. "Most"? Maybe with Python projects (where I still doubt this assertion, but have no experience to know for sure). But otherwise that is definitely not true. Or else why would project.el decide to consider a repository a single project? IME, this kind of projects is a minority.