From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name Date: Fri, 10 Mar 2023 13:59:28 +0200 Message-ID: <83sfeczujj.fsf@gnu.org> References: <87o7p5of4n.fsf@daniel-mendler.de> <871qm01s6n.fsf@web.de> <9fcf05e8-506c-6566-e214-2ecf3194b85e@daniel-mendler.de> <83bkl45ul4.fsf@gnu.org> <87v8j9zl3i.fsf@posteo.net> <83a60l13p2.fsf@gnu.org> <16ecbe9ea8ba9d39d058@heytings.org> <16ecbe9ea85b22d008fd@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33915"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, michael_heerdegen@web.de, mail@daniel-mendler.de, monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, arstoffel@gmail.com To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 13:00:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pabQ6-0008af-15 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 13:00:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pabPq-0003ws-Lr; Fri, 10 Mar 2023 07:00:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabPn-0003w3-KR for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 07:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pabPn-0000YR-Al for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 07:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pabPn-0005E2-2G for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 07:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 12:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62009 X-GNU-PR-Package: emacs Original-Received: via spool by 62009-submit@debbugs.gnu.org id=B62009.167844959820038 (code B ref 62009); Fri, 10 Mar 2023 12:00:03 +0000 Original-Received: (at 62009) by debbugs.gnu.org; 10 Mar 2023 11:59:58 +0000 Original-Received: from localhost ([127.0.0.1]:53911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pabPh-0005D3-U8 for submit@debbugs.gnu.org; Fri, 10 Mar 2023 06:59:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pabPg-0005Cg-K9 for 62009@debbugs.gnu.org; Fri, 10 Mar 2023 06:59:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabPa-0000On-Jn; Fri, 10 Mar 2023 06:59:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3dbOtZE0CcsU/n1JSEqulQf/qLsEWvxe3jt03Lkmw98=; b=X6UoKWf0GLjb YM8N4fbmGMjf0BGlSudXqjz+sn1P1piZDKmxCd8kOsCEim4WgZYIFk/pTvf/w6TRhE8pQANIK11yI idmTL7OYk4NdJtmQlPs1McyJDyIId9FUX289bFXbUae/n8xHKMobGbjexukLwQXFxO2TJqMmyD0VC 9tevgIOXdDTlu39Tgoy+xlZhalGE1NiTRYuQ8LWhLriTQAYLua/4nszCVUCGGK2vO3NNJLW4fbg/H M1/cMxDXyHvttSNp/J6/TQR6NplYKwvxd2HhAC91D/JVTBiUP0XaR28+okJ7X+XA0KUN3lJsVaY9W /jDjYnkt/+ygr3QOUGhF9A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabPY-000848-V1; Fri, 10 Mar 2023 06:59:50 -0500 In-Reply-To: <16ecbe9ea85b22d008fd@heytings.org> (message from Gregory Heytings on Fri, 10 Mar 2023 10:59:03 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257682 Archived-At: > Date: Fri, 10 Mar 2023 10:59:03 +0000 > From: Gregory Heytings > cc: Eli Zaretskii , Philip Kaludercic , > michael_heerdegen@web.de, monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, > Augusto Stoffel > > > Creating a string is not a good idea since it will lead to an > > unacceptably large performance overhead. > > Is "symbol-name" a function that is used in performance-critical code? Yes, it is. Just grep for it. We even call it from C quite a few times. And processing is just one aspect of that; memory and GC is another, not less important. > And did you actually measure that performance overhead before concluding > that it it "unacceptably large"? Anything greater than zero is unacceptably large from where I stand, when the other side of the balance is the use case against which this protects. > > Raising an exception upon modification would be the best approach. > > That would also come with a performance overhead, as there is currently no > way to distinguist strings that are used for symbol names from other > strings. Not to mention the added complexity in the code. Which is why we should do neither.