From: Eli Zaretskii <eliz@gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
Cc: 61996-done@debbugs.gnu.org, theo@thornhill.no, casouri@gmail.com
Subject: bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode
Date: Sun, 12 Mar 2023 17:46:41 +0200 [thread overview]
Message-ID: <83sfeat1jy.fsf@gnu.org> (raw)
In-Reply-To: <87a60i2dsw.fsf@gmail.com> (message from Wilhelm Kirschbaum on Sun, 12 Mar 2023 17:14:03 +0200)
> From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> Cc: 61996@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no
> Date: Sun, 12 Mar 2023 17:14:03 +0200
>
> Attached are the updated patches with added test cases and
> indentation rule enhancements.
Thanks, installed on master.
> I still see this warning on a non-treesitter build:
>
> In elixir-ts--forward-sexp:
> elixir-ts-mode.el:490:8: Warning: reference to free variable
> ‘heex-ts--sexp-regexp’
Doesn't happen here, so I think we are good.
> Random concern: how will backwards compatibility work when the
> grammars get updated?
Let's discuss this when such problems actually happen. The answer
depends on what kind of incompatibilities are introduced by changes in
the grammars.
> It might just be better to add both modes in one patch if more
> changes are required perhaps?
I'm not sure I understand the question.
In general, we like each commit to be as self-contained and
independent of the others as possible. Not sure if this answers your
question.
Thanks, I'm closing this bug.
next prev parent reply other threads:[~2023-03-12 15:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 7:04 bug#61996: 30.0.50; Submitting elixir-ts-mode and heex-ts-mode Wilhelm Kirschbaum
2023-03-06 11:59 ` Eli Zaretskii
2023-03-06 17:23 ` Wilhelm Kirschbaum
2023-03-06 18:36 ` Eli Zaretskii
2023-03-06 19:24 ` Wilhelm Kirschbaum
2023-03-06 20:14 ` Eli Zaretskii
2023-03-11 9:16 ` Eli Zaretskii
2023-03-11 14:16 ` Dmitry Gutov
2023-03-11 18:27 ` Wilhelm Kirschbaum
2023-03-11 18:01 ` Wilhelm Kirschbaum
2023-03-12 9:00 ` Eli Zaretskii
2023-03-12 9:54 ` Wilhelm Kirschbaum
2023-03-12 11:37 ` Eli Zaretskii
2023-03-12 12:23 ` Wilhelm Kirschbaum
2023-03-12 12:32 ` Wilhelm Kirschbaum
2023-03-12 15:14 ` Wilhelm Kirschbaum
2023-03-12 15:46 ` Eli Zaretskii [this message]
2023-03-12 18:02 ` Wilhelm Kirschbaum
2023-03-06 16:41 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfeat1jy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61996-done@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=theo@thornhill.no \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.