From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH 2/3] Add support for styled underlines on tty frames Date: Fri, 21 Apr 2023 20:49:19 +0300 Message-ID: <83sfct2kio.fsf@gnu.org> References: <20230421143448.339022-1-mohkale@kisara.moe> <20230421143448.339022-3-mohkale@kisara.moe> <83y1ml2p8a.fsf@gnu.org> <878rel5fqr.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23166"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62994@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 21 19:50:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pputo-0005pl-OY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Apr 2023 19:50:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pputZ-0001fz-ON; Fri, 21 Apr 2023 13:50:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pputX-0001fh-T0 for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 13:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pputX-0008Dn-6L for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 13:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pputW-0007pQ-F0 for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Apr 2023 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.168209935230025 (code B ref 62994); Fri, 21 Apr 2023 17:50:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 21 Apr 2023 17:49:12 +0000 Original-Received: from localhost ([127.0.0.1]:41090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppusi-0007oC-AP for submit@debbugs.gnu.org; Fri, 21 Apr 2023 13:49:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppusg-0007nz-U4 for 62994@debbugs.gnu.org; Fri, 21 Apr 2023 13:49:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppusY-0007rp-Rf; Fri, 21 Apr 2023 13:49:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qcHPyT7gT7wVWB84sGQdftrXuHIWrUYaim+Nc4sMpN4=; b=heCjEmDqS47f 02+NLPXz8FuMZc4lBw9TEj78lIgMp/Gd3q5GfyjZaXnjCRY/PC/yHaeBoo3hxdhOEFTct2hifwBQg 0QBMqFPfzIJnOPKjzqXB80/BgzmNDLttsaR4NqOAdo5bdi+TsZfGaApbbcA5Vy9+p3KsgvXzVdasp qLA/wpLQbNRn7D4JJFvbyuzwd15R+VyBpYupnB7QsbCjHwSF1EASLOPfEDi5yU7WRes/cQXRYs//1 X1EDC4P1vOe5a+eREpxoORYOUPXUro1aUGXx0W1dunJmROWuvF85l0BocTEyZLrv9e6/hg7KYNTBO xbPHOscuD8pQCz9Z7vK7ew==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppusY-0007D6-Bq; Fri, 21 Apr 2023 13:49:02 -0400 In-Reply-To: <878rel5fqr.fsf@kisara.moe> (message from Mohsin Kaleem on Fri, 21 Apr 2023 18:04:12 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260406 Archived-At: [Please use Reply All to keep the bug address on the CC list.] > From: Mohsin Kaleem > Date: Fri, 21 Apr 2023 18:04:12 +0100 > > Eli Zaretskii writes: > > > I think the last paragraph is unnecessary in NEWS, since there's > > nothing users can do about the capabilities exposed by their terminfo > > database. > > I kinda disagree, I think mentioning this can help users debug why > certain termcaps aren't being processed correctly or to direct requests > to fix the processing directly to the terminal emulator instead of to > Emacs first. I'll go ahead and remove it for now. This is stuff for etc/PROBLEMS, not for NEWS. And we only add it to PROBLEMS if someone actually reports the relevant problems. > > Please use our style of braces and placing of operators in continued > > lines. The brace should be on their own lines, alone. > > For future reference is this style documented anywhere? Yes, in standards.info. This is the GNU recommended style. > > Any pointers to where this standard escape sequence is defined? I'd > > like to have that in a comment to this line. > > For the underline style I think kitty is a good reference since it was > the first to support it. That documentation is here [1]. The sequence > for color is also documented there... but I find the way its described > at best confusing and at worst unhelpful. I've been using the neovim > source code [2] as a reference for the implementation and color sequence > alongside trial and error. > > [1]: https://sw.kovidgoyal.net/kitty/underlines/ > [2]: https://github.com/neovim/neovim/commit/42f492ac99058bd1cd56c3c7871e7e464b2a5e24 Did Kitty invent that? If not, there must be some reference that is not the source code of a terminal emulator.