From: Eli Zaretskii <eliz@gnu.org>
To: Shynur Xie <one.last.kiss@outlook.com>
Cc: 63089@debbugs.gnu.org
Subject: bug#63089: [PATCH] Display offscreen matched openparen
Date: Sat, 29 Apr 2023 14:05:56 +0300 [thread overview]
Message-ID: <83sfcjosmj.fsf@gnu.org> (raw)
In-Reply-To: <SA0PR04MB7433EA61E4194F813DE14859D76B9@SA0PR04MB7433.namprd04.prod.outlook.com> (message from Shynur Xie on Fri, 28 Apr 2023 12:36:03 +0000)
> From: Shynur Xie <one.last.kiss@outlook.com>
> CC: "63089@debbugs.gnu.org" <63089@debbugs.gnu.org>
> Date: Fri, 28 Apr 2023 12:36:03 +0000
>
> > The original code didn't use backticks, so why do you need it in the
> > new version?
>
> My _original_ modification made some lines too long with `list' and
> `cons', so I used all backticks in that function. Since there's no
> such problem in the subsequent modifications, I will use `list' and
> `cons' if you think backticks are unnecessary (or weird).
Backticks usually imply some run-time processing, which AFAIU here is
not required.
> > What is the status of your legal paperwork?
>
> My assignment process with the FSF is complete.
Yes, I see it on file now.
> +(defcustom show-paren-openparen-face-in-message '(:foreground "green")
> + "Set face for the matched offscreen openparen shown in the echo area.
"Face for showing in the echo area matched open paren that is off-screen."
Also, I think the default value should be the default face, so that
the default behavior is not changed.
> +By default, the line containing the matched offscreen openparen is
> +shown in the echo area, where the openparen's face will be propertized
> +by this option."
"face will be propertized: is incorrect: we propertize text with a
face, we don't propertize the face.
> + :type '(choice face sexp (const nil))
> + :version "30.0")
This should be "30.1". Emacs doesn't have NN.0 versions.
> (defun blink-paren-open-paren-line-string (pos)
> - "Return the line string that contains the openparen at POS."
> + "Return the line string that contains the openparen at POS.
> +Remove the line string's properties but give the openparen a face."
This should include the name of the face, so that users could find it
easier.
Thanks.
next prev parent reply other threads:[~2023-04-29 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 13:39 bug#63089: [PATCH] Display offscreen matched openparen Shynur Xie
2023-04-28 6:28 ` Eli Zaretskii
2023-04-28 12:36 ` Shynur Xie
2023-04-29 11:05 ` Eli Zaretskii [this message]
2023-04-30 10:09 ` Shynur Xie
2023-05-01 13:17 ` Eli Zaretskii
2023-05-01 17:52 ` Shynur Xie
2023-05-02 18:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfcjosmj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63089@debbugs.gnu.org \
--cc=one.last.kiss@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.