From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Sat, 01 Jul 2023 17:27:52 +0300 Message-ID: <83sfa7puzb.fsf@gnu.org> References: <87o7ri74qv.fsf@localhost> <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> <83o7l61lz6.fsf@gnu.org> <2aa76ba11fd0a77ba107@heytings.org> <30832e86470f7dc33387@heytings.org> <83r0pyw89y.fsf@gnu.org> <215b00d2590a10728db4@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32355"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, frederic.giquel@laposte.net, yantar92@posteo.net, monnier@iro.umontreal.ca, acm@muc.de To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 01 16:28:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFbaH-0008B0-AZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Jul 2023 16:28:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFba0-00013c-BC; Sat, 01 Jul 2023 10:28:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFbZy-00013H-TZ for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2023 10:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFbZy-0000g3-L1 for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2023 10:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFbZy-0003lf-CY for bug-gnu-emacs@gnu.org; Sat, 01 Jul 2023 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jul 2023 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.168822165314446 (code B ref 60467); Sat, 01 Jul 2023 14:28:02 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 1 Jul 2023 14:27:33 +0000 Original-Received: from localhost ([127.0.0.1]:58428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFbZU-0003kv-Ep for submit@debbugs.gnu.org; Sat, 01 Jul 2023 10:27:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFbZR-0003ki-69 for 60467@debbugs.gnu.org; Sat, 01 Jul 2023 10:27:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFbZJ-0000bF-Cz; Sat, 01 Jul 2023 10:27:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=35RhA178fkUhEnRCsqQgG7i4mL7ElzeVFPuXJojEJlo=; b=fZwdRyb32HXo sreisLOv0/pVHZWGMxSvmI8mdmBpWd8IGieHH7V8ZoN91LrMxyNLV6NFNWMkSiO51xWagJw1jGp3+ btLl/yTzxHzCsyiwnKdKVlUBK4mVG649bg/ME+YZ+Y20G1ahkKnlWUPAVMtqe4ESLJh25yovOKqys 7p6MkypdbCuXDSFHNIZg804+8ZXteE9rdUMrofNdVlV7ehr4evoMrGO4Srxl4fVBUZsXHbh/slQJg HLrTNH5EpDnuoNB5qDiULsCraoRX2101OCK73oG6w6nI8AOQFI6Upw52uxLPhMOG/pjyEV9kEgHAW MDUJM28pcni+1SyJ3p4OEA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFbZI-0004AV-TJ; Sat, 01 Jul 2023 10:27:21 -0400 In-Reply-To: <215b00d2590a10728db4@heytings.org> (message from Gregory Heytings on Sat, 01 Jul 2023 14:14:11 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264409 Archived-At: > Date: Sat, 01 Jul 2023 14:14:11 +0000 > From: Gregory Heytings > cc: 60467@debbugs.gnu.org, frederic.giquel@laposte.net, yantar92@posteo.net, > monnier@iro.umontreal.ca, acm@muc.de > > > >> Well, that bug was already discussed at length six months ago, and the > >> minimal change that was in the end installed (59c3c53efa) introduced a > >> new bug. Should we design another minimal change, at the risk of > >> introducing another bug? ISTM that the safe thing to do is the > >> refactoring that was suggested. > > > > If there's no safer way than the refactoring suggested back then, we > > will have to stay with this regression in Emacs 29.1 and install a > > better fix only on master. After all, the fact that buffer-modified-p > > is not undone is a minor inconvenience at best. > > > > Indeed. A safer way probably exists, but I would not dare writing that > patch. I believe Stefan is in a better position to write it. How about installing your patch, which you proposed back then, on master, then?