From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: mattias.engdegard@gmail.com, 65017@debbugs.gnu.org,
monnier@iro.umontreal.ca, eric.marsden@risk-engineering.org
Subject: bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function
Date: Sun, 06 Aug 2023 07:49:58 +0300 [thread overview]
Message-ID: <83sf8wrczt.fsf@gnu.org> (raw)
In-Reply-To: <ZM6viOS7I4_a0IPp@ACM> (message from Alan Mackenzie on Sat, 5 Aug 2023 20:22:32 +0000)
> Date: Sat, 5 Aug 2023 20:22:32 +0000
> Cc: monnier@iro.umontreal.ca, mattias.engdegard@gmail.com,
> 65017@debbugs.gnu.org, eric.marsden@risk-engineering.org
> From: Alan Mackenzie <acm@muc.de>
>
> > Thanks, but when you have a solution in hand, please also check its
> > effect on performance. AFAIR, this part was tuned for optimal
> > performance, back when symbols with positions were introduced; it
> > would be a pity to lose performance due to fixing this bug, if that
> > can be avoided.
>
> This should really be in bug #65051, but:
>
> I've run
>
> time src/emacs -Q -batch --eval '(let ((a 1) (b 1) (times 10000000)) (while (> times 0) (equal a b) (setq times (1- times))))'
>
> with different values for a and b (and slightly different quoting
> syntax, sometimes). I get the following results, reporting the "user:
> time" from GNU/Linux:
>
> New code:
> a, b = 1, 1: 1.760s 1.760s 1,746s
> a, b = 1, 3: 1.796s 1,772s 1.777s
> 1.0, 1.0: 1,757s 1.776s 1.751s
> 1.0, 1.1: 1.792s 1.760s 1.779s
> '(a b c), '(a b c): 2.041s 2.042s 2.039s
> '(a b c), '(a b d): 2.096s 2.071s 2.084s
> "1", "1": 1.841s 1.860s 1.845s
> "1", "3": 1.865s 1.846s 1.869s
>
> Old code:
> a, b = 1, 1: 1.744s 1.757s 1.762s
> a, b = 1, 3: 1.755s 1,777s 1.759s
> 1.0, 1.0: 1.787s 1.748s 1.775s
> 1.0, 1.1: 1.762s 1.770s 1.774s
> '(a b c), '(a b c): 2.021s 2.057s 2.019s
> '(a b c), '(a b d): 2.046s 2.090s 2.100s
> "1", "1": 1.854s 1.900s 1.884s
> "1", "3": 1.849s 1.833s 1.838s
>
> I think it's fair to say that the new code is not slower than the old
> code, to within the measuring limits of these simple tests. Any
> differences, such as they are, are in the second and third decimal
> places, and vary more between different measurements, than between the
> Old code and New code. They are surely too small to matter.
Thanks, this LGTM.
next prev parent reply other threads:[~2023-08-06 4:49 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 10:28 bug#65017: 29.1; Byte compiler interaction with cl-lib function objects, removes symbol-function Eric Marsden
2023-08-03 9:39 ` Mattias Engdegård
2023-08-03 14:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 15:37 ` Mattias Engdegård
2023-08-03 16:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 16:53 ` Mattias Engdegård
2023-08-03 17:30 ` Mattias Engdegård
2023-08-03 16:43 ` Alan Mackenzie
2023-08-03 17:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 18:22 ` Alan Mackenzie
2023-08-03 21:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 21:10 ` Alan Mackenzie
2023-08-03 21:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 9:55 ` Alan Mackenzie
2023-08-05 22:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 10:14 ` Mattias Engdegård
2023-08-04 11:11 ` Alan Mackenzie
2023-08-04 13:41 ` Mattias Engdegård
2023-08-05 22:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 10:47 ` Mattias Engdegård
2023-08-08 2:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 5:35 ` Eli Zaretskii
2023-08-04 14:16 ` Alan Mackenzie
2023-08-05 20:22 ` Alan Mackenzie
2023-08-06 4:49 ` Eli Zaretskii [this message]
2023-08-04 13:22 ` Alan Mackenzie
2023-08-04 14:04 ` Eli Zaretskii
2023-08-04 14:49 ` Alan Mackenzie
2023-08-04 15:22 ` Eli Zaretskii
2023-08-04 16:43 ` Alan Mackenzie
2023-08-04 17:54 ` Eli Zaretskii
2023-08-05 22:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 22:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 11:59 ` Alan Mackenzie
2023-08-08 2:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-08 16:56 ` Alan Mackenzie
2023-08-10 3:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-10 14:50 ` Alan Mackenzie
2023-08-12 3:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12 9:59 ` Mattias Engdegård
2023-08-12 18:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12 10:40 ` Mattias Engdegård
2023-08-12 16:46 ` Alan Mackenzie
2023-08-12 18:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-13 10:10 ` Alan Mackenzie
2023-08-13 16:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-14 17:10 ` Alan Mackenzie
2023-08-03 16:11 ` Alan Mackenzie
2023-08-03 16:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-03 18:48 ` Alan Mackenzie
2023-08-09 12:27 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sf8wrczt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65017@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eric.marsden@risk-engineering.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.