all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: bruno cuconato <bcclaro@gmail.com>
Cc: 65318@debbugs.gnu.org
Subject: bug#65318: 29.1.50; `comint-run' should read-string with specified history list
Date: Wed, 16 Aug 2023 14:44:08 +0300	[thread overview]
Message-ID: <83sf8j8b5j.fsf@gnu.org> (raw)
In-Reply-To: <87zg2sm58y.fsf@gmail.com> (message from bruno cuconato on Tue, 15 Aug 2023 17:15:41 -0300)

> From: bruno cuconato <bcclaro@gmail.com>
> Date: Tue, 15 Aug 2023 17:15:41 -0300
> 
> 
> Not really a bug, but a feature request. When I run `comint-run' I use
> the history to find the switches I need, and often have to waddle
> through a bunch of unrelated input. As I understand it, that is
> because the interactive `read-string' call does not specify a history
> list (and thus a global one is used, I assume.¹) I'm not sure what the
> best solution is: do we want to add a history list just for the
> switches, or do we want it to be shared with other commands (like
> `shell-command'?), or would any change to the history list argument
> break people's workflows? I for one would prefer the first option.

Since the best solution is not clear, I think we should provide a user
option that would name the history to use, and make it nil by default,
to preserve the current behavior.  Patches welcome.

> ¹: An unrelated mini-bug: `read-string's docstring does not say what
>  happens when the argument is nil, although maybe the manual might do
>  so (I haven't checked). Obviously, one can simply check the C source.

The doc string says to check the documentation of read-from-minibuffer
for the details of HISTORY, and read-from-minibuffer says that if the
argument is nil or omitted, it defaults to minibuffer-history.  So I
think we are okay in that department.

Thanks.





  reply	other threads:[~2023-08-16 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 20:15 bug#65318: 29.1.50; `comint-run' should read-string with specified history list bruno cuconato
2023-08-16 11:44 ` Eli Zaretskii [this message]
2023-08-20 16:58 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sf8j8b5j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=65318@debbugs.gnu.org \
    --cc=bcclaro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.