From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67196: M-: uses a wrong value of debug-on-error when it is nil. Date: Sat, 25 Nov 2023 18:46:05 +0200 Message-ID: <83sf4tbx2q.fsf@gnu.org> References: <83il5qe00e.fsf@gnu.org> <83edgecce4.fsf@gnu.org> <8334wuc7cn.fsf@gnu.org> <83y1elbzny.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18998"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67196@debbugs.gnu.org, monnier@iro.umontreal.ca To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 17:47:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6voH-0004im-9Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 17:47:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6vo2-0007Ct-L8; Sat, 25 Nov 2023 11:46:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6vo1-0007Cc-Dt for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 11:46:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6vo1-0005Qt-5F for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 11:46:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6vo6-00086U-2i for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 11:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67196 X-GNU-PR-Package: emacs Original-Received: via spool by 67196-submit@debbugs.gnu.org id=B67196.170093079031101 (code B ref 67196); Sat, 25 Nov 2023 16:47:02 +0000 Original-Received: (at 67196) by debbugs.gnu.org; 25 Nov 2023 16:46:30 +0000 Original-Received: from localhost ([127.0.0.1]:40107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6vnZ-00085Z-SO for submit@debbugs.gnu.org; Sat, 25 Nov 2023 11:46:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6vnX-00085I-NO for 67196@debbugs.gnu.org; Sat, 25 Nov 2023 11:46:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6vnM-0005Kr-Mn; Sat, 25 Nov 2023 11:46:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N4IYuBHv7Ql3Bd+tsBE7qI7BqMI8obGhU9LliQBdWVo=; b=VcIaurKW6yb7 AO5BD+LRyv+41Yh6IkHDIOWSShJj4G1dWwo7NaKr75CKawtvn7ADPYUVN3Ds8pMdjzzCNBGg1t2zA kS4/bCAuHueV9/KGwbXG4D3r5z35HXbbht7ZwETrrPe7w0UFCGG6SFJFbApmSqn3qrMrF1KpnefDy L99oFkNlsiI61EBBM1P8g+AT9RKDDqBeJ0AKtBvpQLQVnmEdk4ArnHo+ZM0XUn3fDlZX/KHgFJGni Ip/6K0eK/u2XMI9vnN+mZwBcDBVKrpane2ecRXlWsSxkr4PLUzw6m1Jd/+c4eXnE7rTAl/a+fqnUq p0dgZ+rq98kD6YFv4Ib4ig==; In-Reply-To: (message from Alan Mackenzie on Sat, 25 Nov 2023 16:40:40 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275001 Archived-At: > Date: Sat, 25 Nov 2023 16:40:40 +0000 > Cc: monnier@iro.umontreal.ca, 67196@debbugs.gnu.org, acm@muc.de > From: Alan Mackenzie > > > > Instead, the new internal variable > > > debug-from--eval-expression gets set to e-e-debug-on-error. > > > Exactly. And that value can be non-nil, but also not t. That is the > > change I see, and your doc string suggests that it is intentional. > > Thus, we have a behavior change wrt to the value that the body of > > eval-expression will see. And non-nil, non-t values have special > > meaning there. > > OK, I'm with you, now. The non-nil, non-t value in the internal variable > debug-from--e-e won't be seen by any Lisp code. It can be seen by Lisp > code in eval-expression-debug-on-error. > > This is an extension of e-e-debug-on-error to match what debug-on-error > does. I wouldn't think that d-o-e gets set to a list of conditions very > often, but when it does, it's likely very useful. It seemed logical to > extend the same facility to e-e-debug-on-error. Do you think this is a > bad idea? [Clearly, some entries in NEWS will be needed, as well as > amendments to the Elisp manual.] I don't know yet if it is a good idea, I just wanted to point out that your change is not just a bugfix: it actually changes the behavior of eval-expression.