From: Eli Zaretskii <eliz@gnu.org>
To: 4197@emacsbugs.donarmstrong.com
Subject: bug#4197: 23.1; error when try to run `server-start': directory .emacs.d/server is unsafe
Date: Sat, 22 Aug 2009 13:07:04 +0300 [thread overview]
Message-ID: <83r5v4f9h3.fsf@gnu.org> (raw)
In-Reply-To: <834os0hpld.fsf@gnu.org>
> Date: Fri, 21 Aug 2009 23:35:58 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 4197@emacsbugs.donarmstrong.com
>
> > From: "Drew Adams" <drew.adams@oracle.com>
> > Cc: <4197@emacsbugs.donarmstrong.com>, <lennart.borgman@gmail.com>
> > Date: Fri, 21 Aug 2009 11:55:27 -0700
> >
> > But if the default value of the variable is inappropriate for some platform
> > (disk format), then it should be changed - at least on that platform.
> >
> > Can you not test for this (e.g. using code similar to what you asked me to
> > evaluate to test this), and set the default value accordingly?
>
> I don't think we need to change the value of
> w32-get-true-file-attributes on FAT32 volumes. All we need is fix
> server.el to not barf on FAT32 volumes. I'll see what I can do.
Can you please try the following patch to server.el? It is checked in
on the release branch.
2009-08-22 Eli Zaretskii <eliz@gnu.org>
* server.el (server-ensure-safe-dir): Disable the security check
for Windows.
Index: lisp/server.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/server.el,v
retrieving revision 1.192
diff -u -r1.192 server.el
--- lisp/server.el 10 Mar 2009 14:09:26 -0000 1.192
+++ lisp/server.el 22 Aug 2009 10:06:05 -0000
@@ -452,9 +452,10 @@
(unless attrs
(letf (((default-file-modes) ?\700)) (make-directory dir t))
(setq attrs (file-attributes dir)))
- ;; Check that it's safe for use.
- (unless (and (eq t (car attrs)) (eql (nth 2 attrs) (user-uid))
- (or (eq system-type 'windows-nt)
+ ;; Check that it's safe for use. Windows doesn't support
+ ;; Posix-style file security, so don't check there.
+ (unless (or (eq system-type 'windows-nt)
+ (and (eq t (car attrs)) (eql (nth 2 attrs) (user-uid))
(zerop (logand ?\077 (file-modes dir)))))
(error "The directory %s is unsafe" dir))))
next prev parent reply other threads:[~2009-08-22 10:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 3:25 bug#4197: 23.1; error when try to run `server-start': directory .emacs.d/server is unsafe Drew Adams
2009-08-21 9:24 ` Eli Zaretskii
2009-08-21 14:30 ` Drew Adams
2009-08-21 17:43 ` Eli Zaretskii
2009-08-21 18:12 ` Drew Adams
2009-08-21 18:28 ` Eli Zaretskii
2009-08-21 18:55 ` Drew Adams
2009-08-21 20:35 ` Eli Zaretskii
2009-08-21 21:03 ` Drew Adams
2009-08-22 10:07 ` Eli Zaretskii [this message]
2009-08-22 4:49 ` Stefan Monnier
2009-08-22 8:07 ` Eli Zaretskii
2009-08-23 1:57 ` Stefan Monnier
2009-08-23 3:21 ` Eli Zaretskii
2009-08-23 22:30 ` Stefan Monnier
2009-08-22 9:53 ` Jason Rumney
2009-08-22 10:35 ` Eli Zaretskii
2009-08-22 16:59 ` Jason Rumney
2009-08-22 17:10 ` Lennart Borgman
2009-08-23 1:57 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r5v4f9h3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=4197@emacsbugs.donarmstrong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.