From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MS-Windows build broken in Fmake_network_process Date: Sat, 27 Mar 2010 11:50:16 +0300 Message-ID: <83r5n6f8s7.fsf@gnu.org> References: <83634jglab.fsf@gnu.org> <831vf7ge57.fsf@gnu.org> <83y6hfeyzw.fsf@gnu.org> <83vdcig87f.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1269679931 8169 80.91.229.12 (27 Mar 2010 08:52:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 27 Mar 2010 08:52:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 27 09:52:07 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NvRkT-0006cq-K4 for ged-emacs-devel@m.gmane.org; Sat, 27 Mar 2010 09:52:05 +0100 Original-Received: from localhost ([127.0.0.1]:40312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvRkT-00014z-46 for ged-emacs-devel@m.gmane.org; Sat, 27 Mar 2010 04:52:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvRj8-0000Yz-Kn for emacs-devel@gnu.org; Sat, 27 Mar 2010 04:50:42 -0400 Original-Received: from [140.186.70.92] (port=55360 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvRj6-0000Y8-MF for emacs-devel@gnu.org; Sat, 27 Mar 2010 04:50:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvRj5-00025y-OK for emacs-devel@gnu.org; Sat, 27 Mar 2010 04:50:40 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:33829) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvRj5-00025n-H1 for emacs-devel@gnu.org; Sat, 27 Mar 2010 04:50:39 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KZX00200MZXZT00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 27 Mar 2010 11:50:13 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.176.135]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KZX00MJZN7OZ590@a-mtaout20.012.net.il>; Sat, 27 Mar 2010 11:50:13 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122757 Archived-At: > From: Helmut Eller > Cc: emacs-devel@gnu.org > Date: Fri, 26 Mar 2010 22:14:09 +0100 > > If C-g or some other key is pressed during connect this must be > dealt with in some way. Which the previous code did not do > correctly. Please see my other mail in this thread. I think your view of what happens on Windows when the user presses C-g is at least incomplete. I don't argue about this code's correctness or necessity on Posix systems. I accept your and others' expert knowledge about that. What I'm saying is that this code is unneeded and possibly inappropriate on Windows, where most of the system calls and mechanisms involved in this issue work in an entirely different way under the hood. Therefore, I submit that this code should have never been installed unconditionally, at least not without discussing its applicability and implications on Windows.