From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Set the version number in the texinfo manuals using configure Date: Sat, 09 Oct 2010 11:58:32 +0200 Message-ID: <83r5fzn0vr.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1286618329 1244 80.91.229.12 (9 Oct 2010 09:58:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 9 Oct 2010 09:58:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 09 11:58:48 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P4WCT-0007iW-Om for ged-emacs-devel@m.gmane.org; Sat, 09 Oct 2010 11:58:46 +0200 Original-Received: from localhost ([127.0.0.1]:33980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P4WCS-0003qU-VK for ged-emacs-devel@m.gmane.org; Sat, 09 Oct 2010 05:58:45 -0400 Original-Received: from [140.186.70.92] (port=55517 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P4WCI-0003pk-CO for emacs-devel@gnu.org; Sat, 09 Oct 2010 05:58:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P4WCH-0008Ae-8K for emacs-devel@gnu.org; Sat, 09 Oct 2010 05:58:34 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:48870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P4WCG-0008AV-W0; Sat, 09 Oct 2010 05:58:33 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LA000300OZ2HP00@a-mtaout22.012.net.il>; Sat, 09 Oct 2010 11:58:31 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.148.82]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LA00029SP1IRHB0@a-mtaout22.012.net.il>; Sat, 09 Oct 2010 11:58:31 +0200 (IST) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:131524 Archived-At: IMO, the changes introduced with revno 101857 do more trouble than the problem they are supposed to solve. I understand the need to ease the maintenance burden, and support the measures to do so. But I think the means chosen in this case are not well thought out, to say the least. For starters, this breaks the Windows build: make[1]: Entering directory `D:/gnu/bzr/emacs/trunk/doc/emacs' makeinfo --force emacs.texi emacs.texi:8: @include `emacsver.texi': No such file or directory. emacs.texi:32: warning: undefined flag: EMACSVER. emacs.texi:102: warning: undefined flag: EMACSVER. emacs.texi:113: warning: undefined flag: EMACSVER. D:\gnu\bzr\emacs\trunk\doc\emacs//anti.texi:12: warning: undefined flag: EMACSVER. make[1]: *** [../../info/emacs] Error 1 make[1]: Leaving directory `D:/gnu/bzr/emacs/trunk/doc/emacs' make: *** [info-gmake] Error 2 What's worse, I don't know how to solve this cleanly without requiring the end users to have a port of Sed installed. That's because the way emacsver.texi gets created is by using a string generated by the configure script that edits src/emacs.c with Sed. More importantly, I don't understand what is the plan here. Are we going to introduce similar handling into all the other places where the version string is used? If not, why bother with this one alone, when we already have a Lisp program to update them all when a release is tarred? If we are going to do something similar in other places, then let's devise a machinery that could be easily ported to non-Posix platforms, because at least some of these places are specific to those platforms. Such changes should be at least discussed first and the blueprints posted, to make sure all the aspects are understood and solutions exists on all supported platforms. I actually don't understand what's wrong with admin/admin.el that requires to change the way we set version strings in the files that need it. If there are any disadvantages in admin.el, can they be spelled out, please? In addition, these changes have 2 smaller problems: . the file emacsver.texi.in violates the file-name restrictions on DOS filesystems, so it should be renamed to something like emacsver.in . the changes remove the arch-tag from several files -- what is the story here?