From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 1077@debbugs.gnu.org
Subject: bug#1077: 23.0.60; x-create-frame: (wrong-type-argument number-or-marker-p nil)
Date: Tue, 30 Nov 2010 06:05:47 +0200 [thread overview]
Message-ID: <83r5e38nhg.fsf@gnu.org> (raw)
In-Reply-To: <71C125BECEDF4C5E9F703E5743F76893@us.oracle.com>
> From: "Drew Adams" <drew.adams@oracle.com>
> Cc: <1077@debbugs.gnu.org>
> Date: Mon, 29 Nov 2010 13:33:00 -0800
>
> > (define-key menu-bar-showhide-menu [menu-bar-mode]
> > `(menu-item ,(purecopy "Menu-bar") toggle-menu-bar-mode-from-frame
> > :help ,(purecopy "Turn menu-bar on/off")
> > - :button (:toggle . (> (frame-parameter nil 'menu-bar-lines) 0))))
> > + :button (:toggle . (> (frame-parameter (or menu-updating-frame
> > + (selected-frame))
> > + 'menu-bar-lines) 0))))
>
> Ignore if this makes no sense; I'm not following the details of this, and I'm
> ignorant about menu-updating-frame.
>
> Can menu-updating-frame be nil?
It can, but not when we are evaluating menu items as part of creating
a frame. I left the reference to selected-frame for that very reason.
> In that case, don't we get the same error/bug?
I'm not sure. I'm still trying to understand when and why did the
menu-bar-lines parameter got a nil value in the minibuffer frame's
parameters. Depending on what I find, there could be an additional
change. If this happens only in minibuffer frames, then the above
should be enough to fix the bug, because minibuffer frames without a
menu bar will never evaluate their menu items.
next prev parent reply other threads:[~2010-11-30 4:05 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 17:22 bug#1077: 23.0.60; x-create-frame: (wrong-type-argument number-or-marker-p nil) Drew Adams
2008-10-04 16:38 ` Drew Adams
2008-11-22 16:46 ` bug#670: " Drew Adams
2009-10-06 16:19 ` Drew Adams
2010-11-27 2:52 ` Drew Adams
2010-11-27 8:22 ` bug#1077: " Eli Zaretskii
2010-11-27 16:15 ` Drew Adams
2010-11-27 20:10 ` Eli Zaretskii
2010-11-27 23:32 ` Drew Adams
2010-11-28 7:21 ` Eli Zaretskii
2010-11-28 9:50 ` martin rudalics
2010-11-28 13:41 ` Eli Zaretskii
2010-11-28 14:12 ` martin rudalics
2010-11-28 17:29 ` Drew Adams
2010-11-28 17:26 ` Drew Adams
2010-11-28 17:50 ` Eli Zaretskii
2010-11-28 18:42 ` Drew Adams
2010-11-28 19:54 ` Eli Zaretskii
2010-11-28 22:38 ` Drew Adams
2010-11-28 20:43 ` Stefan Monnier
2010-11-28 19:40 ` Eli Zaretskii
2010-11-28 19:46 ` Drew Adams
2010-11-28 20:23 ` Eli Zaretskii
2010-11-29 10:56 ` martin rudalics
2010-11-29 18:58 ` Eli Zaretskii
2010-11-29 20:14 ` martin rudalics
2010-11-29 21:18 ` Eli Zaretskii
2010-11-29 21:33 ` Drew Adams
2010-11-30 4:05 ` Eli Zaretskii [this message]
2010-11-30 7:56 ` martin rudalics
2010-11-30 11:23 ` Eli Zaretskii
2010-11-30 14:01 ` martin rudalics
2010-11-30 15:11 ` Eli Zaretskii
2010-11-30 15:56 ` Drew Adams
2010-11-30 17:07 ` martin rudalics
2010-11-30 17:57 ` Drew Adams
2010-11-30 19:49 ` martin rudalics
2010-11-30 20:16 ` Drew Adams
2010-11-30 18:20 ` Eli Zaretskii
2010-11-30 18:16 ` Eli Zaretskii
2010-11-30 19:16 ` Drew Adams
2010-11-30 17:05 ` martin rudalics
2010-11-30 17:57 ` Drew Adams
2010-11-30 18:27 ` Eli Zaretskii
2010-11-30 19:50 ` martin rudalics
2010-11-30 20:18 ` Drew Adams
2010-12-01 9:58 ` martin rudalics
2010-12-01 15:13 ` Drew Adams
2010-12-01 17:28 ` martin rudalics
2010-12-01 18:19 ` Drew Adams
2010-11-30 19:49 ` martin rudalics
2010-11-30 20:17 ` Drew Adams
2010-11-30 18:18 ` Eli Zaretskii
2010-12-01 9:58 ` martin rudalics
2010-12-01 17:21 ` Eli Zaretskii
2010-12-01 15:05 ` Lennart Borgman
2010-11-30 11:42 ` Eli Zaretskii
2010-11-30 15:42 ` Drew Adams
2010-11-30 18:12 ` Eli Zaretskii
2010-11-30 19:16 ` Drew Adams
2010-12-09 19:11 ` Eli Zaretskii
2010-12-01 15:48 ` Stefan Monnier
2010-12-01 17:27 ` martin rudalics
2010-11-30 20:21 ` Drew Adams
2010-11-30 21:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r5e38nhg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=1077@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.