From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patch make configure.bat support --cflags and --ldflags options that include quotes Date: Fri, 29 Apr 2011 10:30:12 +0300 Message-ID: <83r58l7bwb.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1304062262 26646 80.91.229.12 (29 Apr 2011 07:31:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2011 07:31:02 +0000 (UTC) Cc: Emacs-devel@gnu.org To: Ben Key Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 29 09:30:58 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QFiAB-0006YJ-61 for ged-emacs-devel@m.gmane.org; Fri, 29 Apr 2011 09:30:55 +0200 Original-Received: from localhost ([::1]:44718 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFiAA-0007Xw-0q for ged-emacs-devel@m.gmane.org; Fri, 29 Apr 2011 03:30:54 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFiA6-0007Xr-N4 for Emacs-devel@gnu.org; Fri, 29 Apr 2011 03:30:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFiA5-0007I7-SQ for Emacs-devel@gnu.org; Fri, 29 Apr 2011 03:30:50 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:48438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFiA5-0007I0-E9 for Emacs-devel@gnu.org; Fri, 29 Apr 2011 03:30:49 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LKE00300KSXDC00@a-mtaout20.012.net.il> for Emacs-devel@gnu.org; Fri, 29 Apr 2011 10:30:12 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.124.82.135]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKE003KCKUB3U60@a-mtaout20.012.net.il>; Fri, 29 Apr 2011 10:30:12 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138885 Archived-At: > From: Ben Key > Date: Thu, 28 Apr 2011 19:00:51 -0500 > > I am working on a patch that will configure.bat support --cflags and > --ldflags options that include quotes. For example this patch makes it > possible to configure Emacs as follows > > configure.bat --without-png --without-jpeg --without-gif --without-tiff > --without-xpm --prefix=C:\emacs-24-test > --cflags=-I"C:/Program Files/GnuTLS-2.10.1/include" > --ldflags=-L"C:/Program Files/GnuTLS-2.10.1/lib" --lib gnutls --lib gcrypt > > to build Emacs with GnuTLS support when the GnuTLS files are installed > in ""C:/Program Files/GnuTLS-2.10.1." Thanks. > I made the changes in such a way that configure.bat falls back to the old > behavior if command extensions are not available. Maybe I'm missing something, but where is the fallback, exactly? If command extensions are not available, then what will be the value of fusercflags after this line: +set fusercflags=%usercflags:"=\"% and how will be that value handled by the rest of the batch file? All I see is that you use that value to append a line to config.h, like this: +if (%docflags%) == (Y) echo #define USER_CFLAGS " %fusercflags%">>config.tmp What am I missing?