all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 11080@debbugs.gnu.org
Subject: bug#11080: 24.0.94; Assertion failure in signal handler
Date: Sat, 24 Mar 2012 11:23:31 +0200	[thread overview]
Message-ID: <83r4witkrw.fsf@gnu.org> (raw)
In-Reply-To: <m2bonmqtnx.fsf@linux-m68k.org>

> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sat, 24 Mar 2012 09:39:46 +0100
> 
> > eval.c:3403: Emacs fatal error: assertion failed: !handling_signal
> 
> I think handling_signal should only be incremented in XTread_socket if
> !SYNC_INPUT.  With SYNC_INPUT (which is the default) the SIGIO handler
> doesn't actually call read_avail_input.

Perhaps we should turn the table and ask why do we even have that
eassert inside record_unwind_protect?

The comment to handling_signal says:

  /* Set to non-zero while processing X events.  Checked in Feval to
     make sure the Lisp interpreter isn't called from a signal handler,
     which is unsafe because the interpreter isn't reentrant.  */

But record_unwind_protect is called from any number of places that
have nothing to do with the Lisp interpreter.  Like the one which
triggered this bug, for example.  This assertion makes all of them
potential source of aborts.  If indeed only re-entering Lisp is the
issue here, then is record_unwind_protect really the right place for
making sure we aren't?





  reply	other threads:[~2012-03-24  9:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23 23:24 bug#11080: 24.0.94; Assertion failure in signal handler Johan Bockgård
2012-03-24  6:37 ` Eli Zaretskii
2012-03-24  8:01   ` Eli Zaretskii
2012-03-24 16:32     ` Johan Bockgård
2012-03-24 16:29   ` Johan Bockgård
2012-03-24 18:43     ` Eli Zaretskii
2012-03-24  8:39 ` Andreas Schwab
2012-03-24  9:23   ` Eli Zaretskii [this message]
2012-03-24  9:39     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r4witkrw.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=11080@debbugs.gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.