From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15907: 24.3; Emacs crash due to substitute-command-keys and after-change-functions Date: Sat, 16 Nov 2013 12:29:36 +0200 Message-ID: <83r4aghc6n.fsf@gnu.org> References: <20131115.212301.505338034.artur.malabarba@gmail.com> <83siuwhevv.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1384597875 17041 80.91.229.3 (16 Nov 2013 10:31:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Nov 2013 10:31:15 +0000 (UTC) Cc: 15907-done@debbugs.gnu.org To: bruce.connor.am@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 16 11:31:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vhd9q-0006Bk-Lm for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2013 11:31:18 +0100 Original-Received: from localhost ([::1]:35400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhd9q-0005AW-7x for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Nov 2013 05:31:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhd9h-000596-FV for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 05:31:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhd9b-0006mo-MW for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 05:31:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhd9b-0006mi-J5 for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 05:31:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vhd9b-0001iz-6l for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 05:31:03 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2013 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 15907 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 15907@debbugs.gnu.org, eliz@gnu.org, bruce.connor.am@gmail.com Original-Received: via spool by 15907-done@debbugs.gnu.org id=D15907.13845978216567 (code D ref 15907); Sat, 16 Nov 2013 10:31:02 +0000 Original-Received: (at 15907-done) by debbugs.gnu.org; 16 Nov 2013 10:30:21 +0000 Original-Received: from localhost ([127.0.0.1]:56726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhd8u-0001hq-51 for submit@debbugs.gnu.org; Sat, 16 Nov 2013 05:30:20 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:57839) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhd8r-0001hZ-Ad for 15907-done@debbugs.gnu.org; Sat, 16 Nov 2013 05:30:18 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MWC00G00QB99T00@a-mtaout22.012.net.il> for 15907-done@debbugs.gnu.org; Sat, 16 Nov 2013 12:29:47 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MWC00GYIQHN2H70@a-mtaout22.012.net.il>; Sat, 16 Nov 2013 12:29:47 +0200 (IST) In-reply-to: <83siuwhevv.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80636 Archived-At: > Date: Sat, 16 Nov 2013 11:31:16 +0200 > From: Eli Zaretskii > Cc: 15907@debbugs.gnu.org > > > 1. Start `emacs -Q'; > > 2. Evaluate the following two statements: > > (add-hook 'after-change-functions (lambda (&rest a) (format "%s" 1))) > > (substitute-command-keys "\\{emacs-lisp-mode-map}") > > 3. That's it. Emacs crashes. > > > > The crash doesn't happen if you replace the number 1 with a string or > > a symbol, but it does also happen if you replace it with a list. > > It no longer crashes after changes in trunk revision 115119. > > > This is most annoying as it causes a crash whenever `describe-mode' is > > invoked. > > Since you didn't show any real-life use cases, I'm not sure that the > result is what you wanted, please do check. Actually, I think you will like revision 115120 much better. The underlying problem was that substitute-command-keys sometimes uses an internal buffer, whose changes would trigger your after-change function, which would invoke 'format', which uses the same internal buffer... As I now think I know what was your real-life problem, and it is now fixed, I'm closing this bug report. Feel free to re-open if there are some leftovers. Thanks.