From: Eli Zaretskii <eliz@gnu.org>
To: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Enlarge MAX_ALLOCA?
Date: Thu, 19 Jun 2014 19:48:06 +0300 [thread overview]
Message-ID: <83r42ksv5l.fsf@gnu.org> (raw)
In-Reply-To: <87bnto98ch.fsf@fencepost.gnu.org>
> From: David Kastrup <dak@gnu.org>
> Date: Thu, 19 Jun 2014 18:23:26 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > -#define SAFE_ALLOCA(size) ((size) < MAX_ALLOCA \
> > +#define SAFE_ALLOCA(size) ((size) <= MAX_ALLOCA \
> > ? alloca (size) \
> > : (sa_must_free = true, record_xmalloc (size)))
> >
> > @@ -4469,7 +4469,7 @@ extern void *record_xmalloc (size_t) ATT
> >
> > #define SAFE_ALLOCA_LISP(buf, nelt) \
> > do { \
> > - if ((nelt) < MAX_ALLOCA / word_size) \
> > + if ((nelt) <= MAX_ALLOCA / word_size) \
> > (buf) = alloca ((nelt) * word_size); \
> > else if ((nelt) < min (PTRDIFF_MAX, SIZE_MAX) / word_size) \
> > { \
>
> Bad idea to change < to <= here.
The original macros were inconsistent: some used < and some <=, so I
changed them.
> If there is a hard limit due to short offsets or similar (and if
> there weren't, why bother at all?), then allocating a full 64kB
> might be a bad idea.
Is there really such a system? If so, which one? And why would that
be a worse idea than to allocate the same 64KB off the heap (which is
what that macro does in the 'else' clause? What am I missing?
> 64kB feels arbitrary.
I explained my rationale for choosing this value.
next prev parent reply other threads:[~2014-06-19 16:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 16:02 Enlarge MAX_ALLOCA? Eli Zaretskii
2014-06-19 16:23 ` David Kastrup
2014-06-19 16:48 ` Eli Zaretskii [this message]
2014-06-19 17:04 ` David Kastrup
2014-06-19 17:14 ` Eli Zaretskii
2014-06-19 17:36 ` David Kastrup
2014-06-19 17:51 ` Eli Zaretskii
2014-06-19 18:21 ` Stefan Monnier
2014-06-19 21:13 ` David Kastrup
2014-06-20 7:10 ` Eli Zaretskii
2014-06-20 8:08 ` David Kastrup
2014-06-20 8:38 ` Dmitry Antipov
2014-06-20 8:56 ` Eli Zaretskii
2014-06-20 9:26 ` Andreas Schwab
2014-06-20 9:38 ` David Kastrup
2014-06-19 18:28 ` Stefan Monnier
2014-06-19 18:38 ` Eli Zaretskii
2014-06-19 20:37 ` Stefan Monnier
2014-06-20 7:08 ` Eli Zaretskii
2014-06-20 13:02 ` Stefan Monnier
2014-06-20 13:18 ` Eli Zaretskii
2014-06-20 14:43 ` Stefan Monnier
2014-06-20 14:50 ` Eli Zaretskii
2014-06-20 15:15 ` Herring, Davis
2014-06-20 15:44 ` Dmitry Antipov
2014-06-20 18:36 ` Eli Zaretskii
2014-06-21 13:01 ` K. Handa
2014-06-21 13:59 ` Eli Zaretskii
2014-06-21 17:08 ` Stefan Monnier
2014-06-22 9:22 ` K. Handa
2014-06-28 14:15 ` K. Handa
2014-06-28 14:38 ` Eli Zaretskii
2014-06-21 15:19 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r42ksv5l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dak@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.