From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18545: 24.4.50: Bug - forward-line inside with-selected-window Date: Sun, 28 Sep 2014 19:33:36 +0300 Message-ID: <83r3yvn1r3.fsf@gnu.org> References: <290964377.56621411668876487.JavaMail.www@wwinf7125> <83a95nv9fm.fsf@gnu.org> <542668BA.6010800@gmx.at> <838ul5tpfu.fsf@gnu.org> <54268B0B.1020203@gmx.at> <8361g9tijj.fsf@gnu.org> <5426BD71.4000705@gmx.at> <83zjdlrqti.fsf@gnu.org> <5427099F.6080406@gmx.at> <83tx3ssw5x.fsf@gnu.org> <5427D5F0.9050303@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1411922489 5673 80.91.229.3 (28 Sep 2014 16:41:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Sep 2014 16:41:29 +0000 (UTC) Cc: lompik@voila.fr, 18545@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 28 18:41:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYHXG-00064P-4Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Sep 2014 18:41:22 +0200 Original-Received: from localhost ([::1]:60344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYHXF-0006ak-MI for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Sep 2014 12:41:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYHWx-0006PO-PA for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 12:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYHWo-0004QX-Di for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 12:41:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYHWo-0004Pi-9H for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 12:40:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYHQ9-0007ss-Rv for bug-gnu-emacs@gnu.org; Sun, 28 Sep 2014 12:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Sep 2014 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18545 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18545-submit@debbugs.gnu.org id=B18545.141192203230286 (code B ref 18545); Sun, 28 Sep 2014 16:34:01 +0000 Original-Received: (at 18545) by debbugs.gnu.org; 28 Sep 2014 16:33:52 +0000 Original-Received: from localhost ([127.0.0.1]:54493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYHPz-0007sQ-KA for submit@debbugs.gnu.org; Sun, 28 Sep 2014 12:33:51 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:50280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYHPw-0007sG-IU for 18545@debbugs.gnu.org; Sun, 28 Sep 2014 12:33:49 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NCM00H00DRL8P00@a-mtaout22.012.net.il> for 18545@debbugs.gnu.org; Sun, 28 Sep 2014 19:33:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NCM00HKDE0B8L10@a-mtaout22.012.net.il>; Sun, 28 Sep 2014 19:33:47 +0300 (IDT) In-reply-to: <5427D5F0.9050303@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93825 Archived-At: > Date: Sun, 28 Sep 2014 11:33:36 +0200 > From: martin rudalics > CC: lompik@voila.fr, 18545@debbugs.gnu.org > > >> I don't > >> understand cursor_row_fully_visible_p much. > > > > Which part of it do you not understand? > > Why it should return 1 in these two cases > > if (!MATRIX_ROW_PARTIALLY_VISIBLE_P (w, row)) > return 1; If a row is _not_ partially visible, it is _fully_ visible, right? > and > > if (row->height >= window_height) > { > if (!force_p || MINI_WINDOW_P (w) > || w->vscroll || w->cursor.vpos == 0) > return 1; > } There's a comment that that's supposed to explain this.