From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings Date: Fri, 20 Mar 2015 19:44:37 +0200 Message-ID: <83r3sjva0q.fsf@gnu.org> References: <86twxf68zk.fsf@yandex.ru> <83384zwxdx.fsf@gnu.org> <550C3218.4000903@yandex.ru> <831tkjww0y.fsf@gnu.org> <550C3AB9.7020403@yandex.ru> <83wq2bveq6.fsf@gnu.org> <550C491A.6000909@yandex.ru> <83siczvcss.fsf@gnu.org> <550C504A.10708@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1426873537 22845 80.91.229.3 (20 Mar 2015 17:45:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 17:45:37 +0000 (UTC) Cc: 20154@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 20 18:45:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZ0yv-0000nS-It for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 18:45:13 +0100 Original-Received: from localhost ([::1]:44968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ0yv-0007fi-2t for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 13:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ0yo-0007Yz-NV for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 13:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZ0yl-0004pZ-4x for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 13:45:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ0yl-0004oR-2g for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 13:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZ0yk-0004wy-Bx for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20154-submit@debbugs.gnu.org id=B20154.142687348918964 (code B ref 20154); Fri, 20 Mar 2015 17:45:02 +0000 Original-Received: (at 20154) by debbugs.gnu.org; 20 Mar 2015 17:44:49 +0000 Original-Received: from localhost ([127.0.0.1]:59344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ0yW-0004vm-VU for submit@debbugs.gnu.org; Fri, 20 Mar 2015 13:44:49 -0400 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:55731) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZ0yU-0004v3-BJ for 20154@debbugs.gnu.org; Fri, 20 Mar 2015 13:44:47 -0400 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NLI00300U8RXT00@mtaout27.012.net.il> for 20154@debbugs.gnu.org; Fri, 20 Mar 2015 19:39:21 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLI001WAUDL3B20@mtaout27.012.net.il>; Fri, 20 Mar 2015 19:39:21 +0200 (IST) In-reply-to: <550C504A.10708@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100716 Archived-At: > Date: Fri, 20 Mar 2015 18:52:26 +0200 > From: Dmitry Gutov > CC: 20154@debbugs.gnu.org > > On 03/20/2015 06:44 PM, Eli Zaretskii wrote: > > > To see how much of the time is taken by json-encode-char, replace it > > with something trivial, like 1+, and see what speedup you get. > > Yep. Replacing the second definition with > > (defun json-encode-big-string (str) > (with-temp-buffer > (insert str) > (goto-char (point-min)) > (while (re-search-forward "[\"\\/\b\f\b\r\t]\\|[^ -~]" nil t) > (replace-match "z" t t)) > (format "\"%s\"" (buffer-string)))) > > still makes it take ~100ms on the example string (as opposed to 2ms in > the optimized Python implementation). That's not what I see here. I cannot get the time above 1 sec even with a 1000 time longer input string, if I replace json-encode-char with 1+. So I think your 100ms is the constant overhead of some kind.