From: Eli Zaretskii <eliz@gnu.org>
To: bruce.connor.am@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master b6610d5 2/4: emacs-lisp/package.el: Refactor pre-execute prompt
Date: Mon, 06 Apr 2015 17:15:14 +0300 [thread overview]
Message-ID: <83r3rxjqbx.fsf@gnu.org> (raw)
In-Reply-To: <CAAdUY-+6xM=uf7X5uvpxz-JoVH3mKa_E3GUOA_Dq4OjEL+QvDQ@mail.gmail.com>
> Date: Mon, 6 Apr 2015 15:01:22 +0100
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> > I actually don't understand why those changes were pushed piecemeal,
> > and not as a single commit. They sound like a single changeset to me.
>
> There are many ways to divide changes into changesets. Sorry if mine
> was a little too detailed. The way I learned to do DVCS was to make
> commits small enough to be human-readable, but large enough that each
> one corresponds to a full working state (all tests passing, etc).
What's below follows my personal preferences, so please don't take it
as a mandatory requirement of some sort, just food for thought.
> Each one of these commits makes a significant change to at least 2
> functions, and I found them hard to read in a single commit so I split
> into a few. (In retrospect, the "package-install" commit turned out a
> bit trivial, and could be part of another one).
What I would do in this situation is work on a branch, make
fine-grained commits there, and then merge them all onto master in a
single merge-commit. Then, if someone follows first-parent, they'd
see a single commit with the feature, while still being able to
discern the separate commits you made during development.
IOW, I personally prefer not to see partial commits when I follow
first-parents.
> Do we have an objective definition of what a changeset should be?
No, it's a judgment call. For me, an important question that helps
the decision is "will I ever want to revert that single changeset?"
YMMV, most probably.
next prev parent reply other threads:[~2015-04-06 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150406102057.929.89886@vcs.savannah.gnu.org>
[not found] ` <E1Yf49K-0000G6-N0@vcs.savannah.gnu.org>
2015-04-06 10:51 ` [Emacs-diffs] master b6610d5 2/4: emacs-lisp/package.el: Refactor pre-execute prompt Dmitry Gutov
2015-04-06 11:05 ` Eli Zaretskii
2015-04-06 14:01 ` Artur Malabarba
2015-04-06 14:15 ` Eli Zaretskii [this message]
2015-04-06 15:22 ` Artur Malabarba
2015-04-06 16:01 ` Harald Hanche-Olsen
2015-04-06 16:25 ` Artur Malabarba
2015-04-06 16:54 ` Harald Hanche-Olsen
2015-04-06 17:01 ` Eli Zaretskii
2015-04-06 17:03 ` Harald Hanche-Olsen
2015-04-06 17:40 ` Artur Malabarba
2015-04-07 19:23 ` Stephen J. Turnbull
2015-04-06 13:49 ` Artur Malabarba
2015-04-06 21:22 ` Paul Eggert
2015-04-06 23:41 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r3rxjqbx.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.