From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: etags test is broken on MS-Windows Date: Tue, 19 May 2015 21:26:39 +0300 Message-ID: <83r3qc77a8.fsf@gnu.org> References: <83y4kmdjmj.fsf@gnu.org> <555A8E62.7060700@cs.ucla.edu> <83h9r8egen.fsf@gnu.org> <555B79A5.3020200@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1432060035 7589 80.91.229.3 (19 May 2015 18:27:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 May 2015 18:27:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert , Francesco =?utf-8?Q?Potort=C3=AC?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 19 20:27:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YumEL-0004tV-Qk for ged-emacs-devel@m.gmane.org; Tue, 19 May 2015 20:27:05 +0200 Original-Received: from localhost ([::1]:47705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YumEK-0004JI-MB for ged-emacs-devel@m.gmane.org; Tue, 19 May 2015 14:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YumE7-0004J1-VV for emacs-devel@gnu.org; Tue, 19 May 2015 14:26:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YumE4-0000zU-QN for emacs-devel@gnu.org; Tue, 19 May 2015 14:26:51 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:44618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YumE4-0000yt-I3; Tue, 19 May 2015 14:26:48 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NOM003000I84900@a-mtaout20.012.net.il>; Tue, 19 May 2015 21:26:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOM002Y90KMTH60@a-mtaout20.012.net.il>; Tue, 19 May 2015 21:26:47 +0300 (IDT) In-reply-to: <555B79A5.3020200@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186625 Archived-At: > Date: Tue, 19 May 2015 10:57:57 -0700 > From: Paul Eggert > Cc: emacs-devel@gnu.org > > On 05/19/2015 08:27 AM, Eli Zaretskii wrote: > > I think it's due to DOS CR-LF EOL format of some files in the test suite. > > You're right, I misdiagnosed the porting problem. Sorry about that. Well, I should have thought about that (and tested it) before committing the test suite in the first place. > > If we agree that the problem is due to EOL format, we could try > > thinking about a solution. The root cause for the problem is that on > > Windows, etags accounts for the stripped CR characters, while on Unix > > it treats them as part of the contents, so the byte counts are offset > > by the number of the preceding lines. > > That sounds like a problem, but not a problem that the test case is > trying to detect. A simple way that should cajole the tests into > passing is to remove the trailing CRs from the test data, so I installed > a patch to do that. Thanks. I'm not sure the test suite wasn't trying to test this, though: dostorture.c seems to be an exact copy of torture.c, except for the EOL format. Francesco, can you please comment on this? Given that the Unix build of etags does not remove the CR characters from DOS CR-LF EOLs, what was the purpose of including files with DOS EOLs in the test suite?