all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: xfq.free@gmail.com, simenheg@gmail.com, 21568@debbugs.gnu.org
Subject: bug#21568: [PATCH] Add prettify-symbols-alist for js-mode
Date: Sun, 27 Sep 2015 09:04:09 +0300	[thread overview]
Message-ID: <83r3lkfleu.fsf@gnu.org> (raw)
In-Reply-To: <56074E0F.6060209@yandex.ru>

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sun, 27 Sep 2015 05:01:51 +0300
> Cc: 21568@debbugs.gnu.org
> 
> On 09/27/2015 03:39 AM, Xue Fuqiao wrote:
> 
> > LGTM.  WDYT, Dmitry and Daniel?
> 
> The patch looks fine to me, but I have no idea if Eli meant to add the 
> cookie at the bottom

I have no preferences in this regard.

> or whether that request really makes sense at all.

In general, ELisp files don't have to have these cookies, but I'd
prefer such changes to trigger adding them, if only for educational
purposes, so our contributors are aware of this subtle issue.

> So I'd prefer if he replies as well.

The patch is fine with me.





  reply	other threads:[~2015-09-27  6:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-26 11:49 bug#21568: [PATCH] Add prettify-symbols-alist for js-mode Simen Heggestøyl
2015-09-26 13:32 ` Eli Zaretskii
2015-09-26 15:59   ` Simen Heggestøyl
2015-09-27  0:39     ` Xue Fuqiao
2015-09-27  2:01       ` Dmitry Gutov
2015-09-27  6:04         ` Eli Zaretskii [this message]
2015-09-27  6:12           ` Dmitry Gutov
2015-09-27  7:28             ` Eli Zaretskii
2015-09-27  8:21               ` Dmitry Gutov
2015-09-27  8:39                 ` Eli Zaretskii
2015-09-27  8:50                   ` Dmitry Gutov
2015-09-27 10:03                     ` Eli Zaretskii
2015-09-27 14:11                       ` Dmitry Gutov
2015-09-27 18:37                         ` Eli Zaretskii
2015-09-27 19:13                           ` Dmitry Gutov
2015-09-27 19:46                             ` Eli Zaretskii
2015-09-27 20:18                               ` Dmitry Gutov
2015-09-27 21:01                                 ` Eli Zaretskii
2015-09-28  4:16                                   ` Explicit encoding cookie in Elisp files, was: " Dmitry Gutov
2015-09-28  7:27                                     ` Explicit encoding cookie in Elisp files " Eli Zaretskii
2015-09-28  7:53                                       ` Dmitry Gutov
2015-09-28  8:24                                         ` Eli Zaretskii
2015-09-28 22:54                                           ` Dmitry Gutov
2015-09-27  8:10             ` bug#21568: [PATCH] " Simen Heggestøyl
2015-09-27 14:28         ` Xue Fuqiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r3lkfleu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21568@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=simenheg@gmail.com \
    --cc=xfq.free@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.