From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21548: 25.0.50; [PATCH] Prevent empty -path arguments for not-ignored directories in rgrep's find commands Date: Wed, 30 Sep 2015 10:43:30 +0300 Message-ID: <83r3lgbbdp.fsf@gnu.org> References: <5603DE67.1010903@orcon.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1443676531 30270 80.91.229.3 (1 Oct 2015 05:15:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Oct 2015 05:15:31 +0000 (UTC) Cc: 21548-done@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 01 07:15:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZhWD9-0006U3-E4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Oct 2015 07:15:19 +0200 Original-Received: from localhost ([::1]:38062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhWD8-0003EQ-Kg for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Oct 2015 01:15:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhC3c-0006PC-0l for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 03:44:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhC3W-0000pT-UJ for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 03:44:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhC3W-0000pO-RD for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 03:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZhC3W-0000uT-OX for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2015 03:44:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2015 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 21548@debbugs.gnu.org, eliz@gnu.org, psainty@orcon.net.nz Original-Received: via spool by 21548-done@debbugs.gnu.org id=D21548.14435990003435 (code D ref 21548); Wed, 30 Sep 2015 07:44:02 +0000 Original-Received: (at 21548-done) by debbugs.gnu.org; 30 Sep 2015 07:43:20 +0000 Original-Received: from localhost ([127.0.0.1]:48548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZhC2q-0000tK-0Y for submit@debbugs.gnu.org; Wed, 30 Sep 2015 03:43:20 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:47233) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZhC2m-0000t9-MT for 21548-done@debbugs.gnu.org; Wed, 30 Sep 2015 03:43:17 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NVH00D00C1B7O00@mtaout29.012.net.il> for 21548-done@debbugs.gnu.org; Wed, 30 Sep 2015 10:44:04 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVH00L5MC5GP2A0@mtaout29.012.net.il>; Wed, 30 Sep 2015 10:44:04 +0300 (IDT) In-reply-to: <5603DE67.1010903@orcon.net.nz> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107085 Archived-At: > Date: Thu, 24 Sep 2015 23:28:39 +1200 > From: Phil Sainty > > rgrep's `grep-find-ignored-directories' conditional-ignore behaviour > (for list elements which are cons cells) produces 'find' constraints > like: "find . -type d \( -path -o -path \*/SCCS [...]" (i.e. a -path > argument with no value) when the associated function returns nil. > > The nil elements need to be deleted from the list before the command > line arguments for the ignored directories are generated. Thanks, I pushed this. Please in the future accompany your patches with a ChangeLog-format commit message; see CONTRIBUTE for details. We seem to lack tests for this stuff (and Grep in general). Would you like to write some tests for that? TIA.